From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yuf5S-0002yq-BP for qemu-devel@nongnu.org; Tue, 19 May 2015 06:49:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yuf5P-0006YW-28 for qemu-devel@nongnu.org; Tue, 19 May 2015 06:49:26 -0400 Received: from mail-wg0-x22b.google.com ([2a00:1450:400c:c00::22b]:34928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yuf5O-0006YS-S4 for qemu-devel@nongnu.org; Tue, 19 May 2015 06:49:22 -0400 Received: by wgfl8 with SMTP id l8so12879315wgf.2 for ; Tue, 19 May 2015 03:49:22 -0700 (PDT) Date: Tue, 19 May 2015 11:49:19 +0100 From: Stefan Hajnoczi Message-ID: <20150519104919.GC27737@stefanha-thinkpad.redhat.com> References: <1431599702-10431-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="z4+8/lEcDcG5Ke9S" Content-Disposition: inline In-Reply-To: <1431599702-10431-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: get_block_status: use "else" when testing the opposite condition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com --z4+8/lEcDcG5Ke9S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 14, 2015 at 12:35:02PM +0200, Paolo Bonzini wrote: > A bit of Boolean algebra (and common sense) tells us that the > second "if" here is looking for blocks that are not allocated. > This is the opposite of the "if" that sets BDRV_BLOCK_ALLOCATED, > and thus it can use an "else". >=20 > Signed-off-by: Paolo Bonzini > --- > block/io.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --z4+8/lEcDcG5Ke9S Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVWxUvAAoJEJykq7OBq3PIP/cIAMfJKBctm6aCcdkectO5kowc xQPH0fSJ8V154WAaGUr8Q9dC+Xa4Fbg9OzM9FtAverO+3YXWHVWhT4TwE1YlPLSL se1+ABi4xDafXw8TIOusB72Ch2KKGSOlIkE+23vb4Q2buRQ7BLEeXZVLCdI2ARgv k6NIdTkgEZL0d18rf14qpdRpCpl4FX7/Z4dhaZY5C5ERZ5388pcLoNMnYQnYP4hd cB+XonqeKGKazKpXxm9Zi4DWAZ4WPFX/3hCG0YOL53N8ycs1aS/3oBGvWuJYzqKg iGCITCC9TAkM+9GV/kTvoMFelcCTvsCiKHCUuUx/mwcrInkbdIIXAQDOk4jqgVk= =I4OK -----END PGP SIGNATURE----- --z4+8/lEcDcG5Ke9S--