From: Stefan Hajnoczi <stefanha@gmail.com>
To: sfeldma@gmail.com
Cc: jiri@resnulli.us, qemu-devel@nongnu.org, dsahern@gmail.com
Subject: Re: [Qemu-devel] [PATCH 1/4] rocker: Add support for phys name
Date: Tue, 19 May 2015 14:37:40 +0100 [thread overview]
Message-ID: <20150519133740.GD9338@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1431583614-20100-2-git-send-email-sfeldma@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 874 bytes --]
On Wed, May 13, 2015 at 11:06:51PM -0700, sfeldma@gmail.com wrote:
> diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c
> index 55b6c46..f62fb95 100644
> --- a/hw/net/rocker/rocker.c
> +++ b/hw/net/rocker/rocker.c
> @@ -15,6 +15,7 @@
> * GNU General Public License for more details.
> */
>
> +#include <net/if.h>
This breaks Windows builds:
hw/net/rocker/rocker.c:18:20: fatal error: net/if.h: No such file or directory
#include <net/if.h>
^
On Fedora, check out the mingw64- packages if you a cross toolchain. On
other distros you can use http://mxe.cc/ to get a cross toolchain.
<net/if.h> is POSIX but Windows doesn't seem to have it:
http://pubs.opengroup.org/onlinepubs/009696699/basedefs/net/if.h.html
Note that IF_NAMESIZE is POSIX and might be more widely available than
IFNAMSIZ (BSD).
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-05-19 13:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 6:06 [Qemu-devel] [PATCH 0/4] rocker device updates sfeldma
2015-05-14 6:06 ` [Qemu-devel] [PATCH 1/4] rocker: Add support for phys name sfeldma
2015-05-19 13:37 ` Stefan Hajnoczi [this message]
2015-05-14 6:06 ` [Qemu-devel] [PATCH 2/4] rocker: update tests using hw-derived interface names sfeldma
2015-05-19 13:38 ` Stefan Hajnoczi
2015-05-14 6:06 ` [Qemu-devel] [PATCH 3/4] rocker: bring link up/down on PHY enable/disable sfeldma
2015-05-19 13:38 ` Stefan Hajnoczi
2015-05-14 6:06 ` [Qemu-devel] [PATCH 4/4] qmp/hmp: add rocker device support sfeldma
2015-05-19 13:59 ` Stefan Hajnoczi
2015-06-20 21:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519133740.GD9338@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=dsahern@gmail.com \
--cc=jiri@resnulli.us \
--cc=qemu-devel@nongnu.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).