From: Stefan Hajnoczi <stefanha@gmail.com>
To: sfeldma@gmail.com
Cc: jiri@resnulli.us, qemu-devel@nongnu.org, dsahern@gmail.com
Subject: Re: [Qemu-devel] [PATCH 3/4] rocker: bring link up/down on PHY enable/disable
Date: Tue, 19 May 2015 14:38:52 +0100 [thread overview]
Message-ID: <20150519133852.GF9338@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1431583614-20100-4-git-send-email-sfeldma@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
On Wed, May 13, 2015 at 11:06:53PM -0700, sfeldma@gmail.com wrote:
> From: Scott Feldman <sfeldma@gmail.com>
>
> When the OS driver enables/disables the port, go ahead and set the port's
> link status to up/down in response to the change. This more closely
> emulates real hardware when the PHY for the port is brought up/down
> and the PHY negotiates carrier (link status) with link partner. In
> the case of qemu, the virtual rocker device can't really do link
> negotiation with the link partner as that requires signally over a
> physical medium (the wire), so just pretend the negotiation was
> successful and bring the link up when the port is enabled.
>
> Signed-off-by: Scott Feldman <sfeldma@gmail.com>
> ---
> hw/net/rocker/rocker_fp.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-05-19 13:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 6:06 [Qemu-devel] [PATCH 0/4] rocker device updates sfeldma
2015-05-14 6:06 ` [Qemu-devel] [PATCH 1/4] rocker: Add support for phys name sfeldma
2015-05-19 13:37 ` Stefan Hajnoczi
2015-05-14 6:06 ` [Qemu-devel] [PATCH 2/4] rocker: update tests using hw-derived interface names sfeldma
2015-05-19 13:38 ` Stefan Hajnoczi
2015-05-14 6:06 ` [Qemu-devel] [PATCH 3/4] rocker: bring link up/down on PHY enable/disable sfeldma
2015-05-19 13:38 ` Stefan Hajnoczi [this message]
2015-05-14 6:06 ` [Qemu-devel] [PATCH 4/4] qmp/hmp: add rocker device support sfeldma
2015-05-19 13:59 ` Stefan Hajnoczi
2015-06-20 21:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519133852.GF9338@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=dsahern@gmail.com \
--cc=jiri@resnulli.us \
--cc=qemu-devel@nongnu.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).