From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YujTU-0004AZ-62 for qemu-devel@nongnu.org; Tue, 19 May 2015 11:30:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YujTP-0006aD-Fg for qemu-devel@nongnu.org; Tue, 19 May 2015 11:30:32 -0400 Date: Tue, 19 May 2015 17:30:10 +0200 From: Kashyap Chamarthy Message-ID: <20150519153010.GG4838@tesla.redhat.com> References: <1431385466-4868-1-git-send-email-jsnow@redhat.com> <1431385466-4868-12-git-send-email-jsnow@redhat.com> <555A11BE.8090105@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <555A11BE.8090105@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 11/11] qmp-commands.hx: Update the supported 'transaction' operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, vsementsov@parallels.com, stefanha@redhat.com, John Snow On Mon, May 18, 2015 at 06:22:22PM +0200, Max Reitz wrote: > On 12.05.2015 01:04, John Snow wrote: > >From: Kashyap Chamarthy > > > >Although the canonical source of reference for QMP commands is > >qapi-schema.json, for consistency's sake, update qmp-commands.hx to > >state the list of supported transactionable operations, namely: > > > > drive-backup > > blockdev-backup > > blockdev-snapshot-internal-sync > > abort > > block-dirty-bitmap-add > > block-dirty-bitmap-clear > > > >Signed-off-by: Kashyap Chamarthy > >Reviewed-by: Eric Blake > >Signed-off-by: John Snow > >--- > > qmp-commands.hx | 13 ++++++++----- > > 1 file changed, 8 insertions(+), 5 deletions(-) > > > >diff --git a/qmp-commands.hx b/qmp-commands.hx > >index 7506774..363126a 100644 > >--- a/qmp-commands.hx > >+++ b/qmp-commands.hx > >@@ -1238,11 +1238,14 @@ SQMP > > transaction > > ----------- > >-Atomically operate on one or more block devices. The only supported operations > >-for now are drive-backup, internal and external snapshotting. A list of > >-dictionaries is accepted, that contains the actions to be performed. > >-If there is any failure performing any of the operations, all operations > >-for the group are abandoned. > >+Atomically operate on one or more block devices. Operations that are > >+currently supported: drive-backup, blockdev-backup, > >+blockdev-snapshot-sync, blockdev-snapshot-internal-sync, abort, > >+block-dirty-bitmap-add, block-dirty-bitmap-clear > > Hm, seven operations... Worth making it a real list? I don't have a preference. FWIW, I think it still retains the readability. And, not sure if it's worth the churn. > >(refer to the > >+qemu/qapi-schema.json file for minimum required QEMU versions for these > >+operations). A list of dictionaries is accepted, that contains the > >+actions to be performed. If there is any failure performing any of the > >+operations, all operations for the group are abandoned. > > For external snapshots, the dictionary contains the device, the file to use for > > the new snapshot, and the format. The default format, if not specified, is > -- /kashyap