From: Fam Zheng <famz@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-block@nongnu.org, Juan Quintela <quintela@redhat.com>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, Vincenzo Maffione <v.maffione@gmail.com>,
"Vassili Karpov (malc)" <av1474@comtv.ru>,
Gerd Hoffmann <kraxel@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Amit Shah <amit.shah@redhat.com>,
Giuseppe Lettieri <g.lettieri@iet.unipi.it>,
Luigi Rizzo <rizzo@iet.unipi.it>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 00/13] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2
Date: Wed, 20 May 2015 14:38:03 +0800 [thread overview]
Message-ID: <20150520063803.GE6219@ad.nay.redhat.com> (raw)
In-Reply-To: <555C2917.2060101@redhat.com>
On Wed, 05/20 08:26, Paolo Bonzini wrote:
>
>
> On 19/05/2015 17:02, Stefan Hajnoczi wrote:
> > 1. Convert everything like you converted qemu-nbd.c. This is a
> > conservative approach and we can be confident that behavior is
> > unchanged.
>
> So, that means whenever you change receive_disabled you call a new
> callback on the peer? In addition, whenever the count of
> receive-disabled ports switches from zero to non-zero or vice versa,
> hubs need to inform all its ports.
>
> There are just two places that set/clear receive_disabled,
> qemu_deliver_packet and qemu_flush_or_purge_queued_packets, but I
> think a new API is needed to implement the callback for hubs
> (qemu_send_enable/qemu_send_disable).
>
I think .can_receive is the harder one, I'm not sure it's feasible - each
device has its own set of conditions, so it will be a huge change.
Fam
next prev parent reply other threads:[~2015-05-20 6:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 10:50 [Qemu-devel] [PATCH v3 00/13] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2 Fam Zheng
2015-05-19 10:50 ` [Qemu-devel] [PATCH v3 01/13] stubs: Add qemu_set_fd_handler Fam Zheng
2015-05-19 10:50 ` [Qemu-devel] [PATCH v3 02/13] qemu-nbd: Switch to qemu_set_fd_handler Fam Zheng
2015-05-19 6:02 ` Amit Shah
2015-05-19 6:09 ` Amit Shah
2015-05-19 14:39 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 03/13] l2tpv3: Drop l2tpv3_can_send Fam Zheng
2015-05-19 14:48 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-05-26 6:52 ` Fam Zheng
2015-05-26 9:07 ` Stefan Hajnoczi
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 04/13] netmap: Drop netmap_can_send Fam Zheng
2015-05-19 14:54 ` Stefan Hajnoczi
2015-05-25 3:51 ` Fam Zheng
2015-05-26 9:18 ` Stefan Hajnoczi
2015-05-27 7:24 ` Fam Zheng
2015-06-02 16:24 ` Stefan Hajnoczi
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 05/13] net/socket: Drop net_socket_can_send Fam Zheng
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 06/13] tap: Drop tap_can_send Fam Zheng
2015-06-02 16:21 ` Stefan Hajnoczi
2015-06-03 7:35 ` Fam Zheng
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 07/13] Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler Fam Zheng
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 08/13] main-loop: Drop qemu_set_fd_handler2 Fam Zheng
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 09/13] alsaaudio: Remove unused error handling of qemu_set_fd_handler Fam Zheng
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 10/13] oss: " Fam Zheng
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 11/13] xen_backend: " Fam Zheng
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 12/13] event-notifier: Always return 0 for posix implementation Fam Zheng
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 13/13] iohandler: Change return type of qemu_set_fd_handler to "void" Fam Zheng
2015-05-19 15:02 ` [Qemu-devel] [Qemu-block] [PATCH v3 00/13] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2 Stefan Hajnoczi
2015-05-20 4:35 ` Fam Zheng
2015-05-20 6:26 ` Paolo Bonzini
2015-05-20 6:38 ` Fam Zheng [this message]
2015-05-20 7:39 ` [Qemu-devel] " Paolo Bonzini
2015-05-20 8:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520063803.GE6219@ad.nay.redhat.com \
--to=famz@redhat.com \
--cc=amit.shah@redhat.com \
--cc=av1474@comtv.ru \
--cc=g.lettieri@iet.unipi.it \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rizzo@iet.unipi.it \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
--cc=v.maffione@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).