From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv1vC-0007W0-VQ for qemu-devel@nongnu.org; Wed, 20 May 2015 07:12:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yv1vB-0001ug-Vg for qemu-devel@nongnu.org; Wed, 20 May 2015 07:12:22 -0400 Date: Wed, 20 May 2015 13:12:13 +0200 From: Kashyap Chamarthy Message-ID: <20150520111213.GB6856@tesla.redhat.com> References: <1431385466-4868-1-git-send-email-jsnow@redhat.com> <1431385466-4868-12-git-send-email-jsnow@redhat.com> <555A11BE.8090105@redhat.com> <20150519153010.GG4838@tesla.redhat.com> <555B58BC.5030909@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <555B58BC.5030909@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 11/11] qmp-commands.hx: Update the supported 'transaction' operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz , vsementsov@parallels.com, stefanha@redhat.com On Tue, May 19, 2015 at 11:37:32AM -0400, John Snow wrote: > > On Mon, May 18, 2015 at 06:22:22PM +0200, Max Reitz wrote: > >> On 12.05.2015 01:04, John Snow wrote: [. . .] > >>> diff --git a/qmp-commands.hx b/qmp-commands.hx > >>> index 7506774..363126a 100644 > >>> --- a/qmp-commands.hx > >>> +++ b/qmp-commands.hx > >>> @@ -1238,11 +1238,14 @@ SQMP > >>> transaction > >>> ----------- > >>> -Atomically operate on one or more block devices. The only supported operations > >>> -for now are drive-backup, internal and external snapshotting. A list of > >>> -dictionaries is accepted, that contains the actions to be performed. > >>> -If there is any failure performing any of the operations, all operations > >>> -for the group are abandoned. > >>> +Atomically operate on one or more block devices. Operations that are > >>> +currently supported: drive-backup, blockdev-backup, > >>> +blockdev-snapshot-sync, blockdev-snapshot-internal-sync, abort, > >>> +block-dirty-bitmap-add, block-dirty-bitmap-clear > >> > >> Hm, seven operations... Worth making it a real list? > > > > I don't have a preference. FWIW, I think it still retains the > > readability. And, not sure if it's worth the churn. > > > >>> (refer to the > >>> +qemu/qapi-schema.json file for minimum required QEMU versions for these > >>> +operations). A list of dictionaries is accepted, that contains the > >>> +actions to be performed. If there is any failure performing any of the > >>> +operations, all operations for the group are abandoned. > >>> For external snapshots, the dictionary contains the device, the file to use for > >>> the new snapshot, and the format. The default format, if not specified, is > >> > > > > I have to respin the series anyway, so if you want Kashyap, you can > rewrite this and send it to me privately for inclusion Done. Sent you (and Max) the revised patch. Max provided his R-b. Max wondered whether you'd include this in your series on #qemu. I'll assume you'll do. Thanks. -- /kashyap