qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Richard Henderson <rth@twiddle.net>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] virtio-pci msix error
Date: Wed, 20 May 2015 19:55:48 +0800	[thread overview]
Message-ID: <20150520115548.GG6219@ad.nay.redhat.com> (raw)
In-Reply-To: <CAFEAcA-bBCcKpbDTjOSh8o2=-_drHfcnEJQPopQ7q=1ctDf+mQ@mail.gmail.com>

On Wed, 05/20 11:41, Peter Maydell wrote:
> On 20 May 2015 at 10:58, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, May 19, 2015 at 09:11:26PM +0100, Peter Maydell wrote:
> >> On 19 May 2015 at 20:16, Michael S. Tsirkin <mst@redhat.com> wrote:
> >> > On Tue, May 19, 2015 at 08:54:36AM -0700, Richard Henderson wrote:
> >> >> Re patch c7ff5482.  What's the point of this error?
> >> >> It's going to always appear for older targets that
> >> >> predate such new fangled things as msix.
> >> >>
> >> >> Obviously the patch has been there a while, and it's
> >> >> not actually causing any problems, but today it got
> >> >> on my nerves...
> >>
> >> > So don't specify nvectors > 0 for these platforms then?
> >>
> >> How do you do that? I did a quick 'git grep' for nvectors
> >> and none of the hits are in platform-dependent code...
> >>
> >> Why can't the virtio-pci device automatically detect
> >> whether the PCI bus it's plugged into supports MSIx
> >> and just do the right thing?
> 
> > I mean why does *user* specify nvectors > 0?
> 
> The user isn't specifying nvectors at all. That's why
> the message is annoying...

So I think it's better to fix the default for old targets?

Fam

  reply	other threads:[~2015-05-20 11:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 15:54 [Qemu-devel] virtio-pci msix error Richard Henderson
2015-05-19 19:16 ` Michael S. Tsirkin
2015-05-19 20:11   ` Peter Maydell
2015-05-19 20:29     ` [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all Richard Henderson
2015-05-20  9:59       ` Michael S. Tsirkin
2015-05-20 15:10         ` Richard Henderson
2015-05-21 18:51           ` Mark Cave-Ayland
2015-07-03  8:22       ` Mark Cave-Ayland
2015-07-06 10:38         ` Peter Maydell
2015-09-27 14:40           ` Peter Maydell
2015-10-26  9:44             ` Mark Cave-Ayland
2015-10-26 10:03               ` Michael S. Tsirkin
2015-10-26 10:09                 ` Mark Cave-Ayland
2015-10-26 10:14                   ` Peter Maydell
2015-10-26 10:29                     ` Michael S. Tsirkin
2015-10-26 10:47                     ` Mark Cave-Ayland
2015-10-26 11:08                       ` Michael S. Tsirkin
2015-05-20  9:58     ` [Qemu-devel] virtio-pci msix error Michael S. Tsirkin
2015-05-20 10:41       ` Peter Maydell
2015-05-20 11:55         ` Fam Zheng [this message]
2015-05-20 12:10           ` Peter Maydell
2015-06-13 15:06             ` Mark Cave-Ayland
2015-07-03  8:13               ` Mark Cave-Ayland
2015-07-03  8:16                 ` Peter Maydell
2015-07-03  8:19                   ` Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150520115548.GG6219@ad.nay.redhat.com \
    --to=famz@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).