From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45194)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Yv2bM-0006eE-7y
	for qemu-devel@nongnu.org; Wed, 20 May 2015 07:55:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Yv2bI-00070M-8J
	for qemu-devel@nongnu.org; Wed, 20 May 2015 07:55:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50946)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Yv2bI-0006zq-1M
	for qemu-devel@nongnu.org; Wed, 20 May 2015 07:55:52 -0400
Date: Wed, 20 May 2015 19:55:48 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150520115548.GG6219@ad.nay.redhat.com>
References: <555B5CBC.1090709@twiddle.net>
	<20150519181735-mutt-send-email-mst@redhat.com>
	<CAFEAcA8Up48WkbgNdyyXQKJQhJj=G-NHde8fwKwsdSTPpxEkRg@mail.gmail.com>
	<20150520115740-mutt-send-email-mst@redhat.com>
	<CAFEAcA-bBCcKpbDTjOSh8o2=-_drHfcnEJQPopQ7q=1ctDf+mQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA-bBCcKpbDTjOSh8o2=-_drHfcnEJQPopQ7q=1ctDf+mQ@mail.gmail.com>
Subject: Re: [Qemu-devel] virtio-pci msix error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Richard Henderson <rth@twiddle.net>, qemu-devel <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>

On Wed, 05/20 11:41, Peter Maydell wrote:
> On 20 May 2015 at 10:58, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, May 19, 2015 at 09:11:26PM +0100, Peter Maydell wrote:
> >> On 19 May 2015 at 20:16, Michael S. Tsirkin <mst@redhat.com> wrote:
> >> > On Tue, May 19, 2015 at 08:54:36AM -0700, Richard Henderson wrote:
> >> >> Re patch c7ff5482.  What's the point of this error?
> >> >> It's going to always appear for older targets that
> >> >> predate such new fangled things as msix.
> >> >>
> >> >> Obviously the patch has been there a while, and it's
> >> >> not actually causing any problems, but today it got
> >> >> on my nerves...
> >>
> >> > So don't specify nvectors > 0 for these platforms then?
> >>
> >> How do you do that? I did a quick 'git grep' for nvectors
> >> and none of the hits are in platform-dependent code...
> >>
> >> Why can't the virtio-pci device automatically detect
> >> whether the PCI bus it's plugged into supports MSIx
> >> and just do the right thing?
> 
> > I mean why does *user* specify nvectors > 0?
> 
> The user isn't specifying nvectors at all. That's why
> the message is annoying...

So I think it's better to fix the default for old targets?

Fam