From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv0md-0008JH-7A for qemu-devel@nongnu.org; Wed, 20 May 2015 05:59:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yv0mV-0006W6-Pk for qemu-devel@nongnu.org; Wed, 20 May 2015 05:59:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv0mV-0006Vm-Ds for qemu-devel@nongnu.org; Wed, 20 May 2015 05:59:19 -0400 Date: Wed, 20 May 2015 11:59:14 +0200 From: "Michael S. Tsirkin" Message-ID: <20150520115838-mutt-send-email-mst@redhat.com> References: <1432067391-19834-1-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432067391-19834-1-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org On Tue, May 19, 2015 at 01:29:51PM -0700, Richard Henderson wrote: > And do not issue an error_report in that case. > > Signed-off-by: Richard Henderson > --- > hw/virtio/virtio-pci.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > -- > > This seems to be about the only sane way to test the value of > msi_supported from here. Thoughts? > > > r~ Can you please include the qemu command-line that triggers the error in the commit log? > > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index 867c9d1..6763872 100644 > --- a/hw/virtio/virtio-pci.c > +++ b/hw/virtio/virtio-pci.c > @@ -934,11 +934,16 @@ static void virtio_pci_device_plugged(DeviceState *d) > pci_set_word(config + PCI_SUBSYSTEM_ID, virtio_bus_get_vdev_id(bus)); > config[PCI_INTERRUPT_PIN] = 1; > > - if (proxy->nvectors && > - msix_init_exclusive_bar(&proxy->pci_dev, proxy->nvectors, 1)) { > - error_report("unable to init msix vectors to %" PRIu32, > - proxy->nvectors); > - proxy->nvectors = 0; > + if (proxy->nvectors) { > + int err = msix_init_exclusive_bar(&proxy->pci_dev, proxy->nvectors, 1); > + if (err) { > + /* Notice when a system that supports MSIx can't initialize it. */ > + if (err != -ENOTSUP) { > + error_report("unable to init msix vectors to %" PRIu32, > + proxy->nvectors); > + } > + proxy->nvectors = 0; > + } > } > > proxy->pci_dev.config_write = virtio_write_config; > -- > 2.1.0