From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv4ND-0004QJ-Kz for qemu-devel@nongnu.org; Wed, 20 May 2015 09:49:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yv4N8-000094-T2 for qemu-devel@nongnu.org; Wed, 20 May 2015 09:49:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv4N8-00008t-Nq for qemu-devel@nongnu.org; Wed, 20 May 2015 09:49:22 -0400 Date: Wed, 20 May 2015 15:49:16 +0200 From: Igor Mammedov Message-ID: <20150520154916.20fd14c0@nial.brq.redhat.com> In-Reply-To: <555C6FDA.2090607@huawei.com> References: <1431595182-7552-6-git-send-email-zhaoshenglong@huawei.com> <1432095782-13992-1-git-send-email-zhaoshenglong@huawei.com> <20150520130538.0fe532ce@nial.brq.redhat.com> <555C6FDA.2090607@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RESEND PATCH 05/23] hw/acpi/aml-build: Add aml_interrupt() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, lersek@redhat.com, mst@redhat.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, hanjun.guo@linaro.org, pbonzini@redhat.com, alex.bennee@linaro.org, christoffer.dall@linaro.org, shannon.zhao@linaro.org On Wed, 20 May 2015 19:28:26 +0800 Shannon Zhao wrote: > > > On 2015/5/20 19:05, Igor Mammedov wrote: > > On Wed, 20 May 2015 12:23:02 +0800 > > Shannon Zhao wrote: > > > >> > From: Shannon Zhao > >> > > >> > Add aml_interrupt() for describing device interrupt in resource template. > >> > These can be used to generating DSDT table for ACPI on ARM. > >> > > >> > Signed-off-by: Shannon Zhao > >> > Signed-off-by: Shannon Zhao > >> > --- > >> > hw/acpi/aml-build.c | 22 ++++++++++++++++++++++ > >> > include/hw/acpi/aml-build.h | 42 ++++++++++++++++++++++++++++++++++++++++++ > >> > 2 files changed, 64 insertions(+) > >> > > >> > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > >> > index 805a0ad..5f06367 100644 > >> > --- a/hw/acpi/aml-build.c > >> > +++ b/hw/acpi/aml-build.c > >> > @@ -531,6 +531,28 @@ Aml *aml_memory32_fixed(uint32_t addr, uint32_t size, > >> > return var; > >> > } > >> > > >> > +/* > >> > + * ACPI 5.0: 6.4.3.6 Extended Interrupt Descriptor > >> > + * Type 1, Large Item Name 0x9 > >> > + */ > >> > +Aml *aml_interrupt(AmlConsumerAndProducer con_and_pro, > >> > + AmlLevelAndEdge level_and_edge, > >> > + AmlActiveHighAndLow high_and_low, AmlShared shared, > >> > + uint32_t irq) > >> > +{ > >> > + Aml *var = aml_alloc(); > >> > + uint8_t irq_flags = con_and_pro | (level_and_edge << 1) > >> > + | (high_and_low << 2) | (shared << 3); > >> > + > >> > + build_append_byte(var->buf, 0x89); /* Extended irq descriptor */ > >> > + build_append_byte(var->buf, 6); /* Length, bits[7:0] minimum value = 6 */ > >> > + build_append_byte(var->buf, 0); /* Length, bits[15:8] minimum value = 0 */ > >> > + build_append_byte(var->buf, irq_flags); /* Interrupt Vector Information. */ > >> > + build_append_byte(var->buf, 0x01); /* Interrupt table length = 1 */ > >> > + build_append_4bytes(var->buf, irq); /* Interrupt Number */ > > Just looking at the patch I have no idea what above line does; > > > > using 4 build_append_byte() is much clearer and matches the spec 1:1 > > when comparing. > > > > I feel awkward and have no word to convince you. If you insist on this, > I'll go back to 4 build_append_byte(). I've chatted with Michael about it, he doesn't insist on build_append_4bytes() ans he is ok with using build_append_byte() 4 times.