From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvJBs-00027c-Vu for qemu-devel@nongnu.org; Thu, 21 May 2015 01:38:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvJBp-0005IN-I3 for qemu-devel@nongnu.org; Thu, 21 May 2015 01:38:44 -0400 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:47113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvJBo-0005GS-V4 for qemu-devel@nongnu.org; Thu, 21 May 2015 01:38:41 -0400 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 21 May 2015 15:38:37 +1000 Received: from d23relay07.au.ibm.com (d23relay07.au.ibm.com [9.190.26.37]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 6F7322CE8040 for ; Thu, 21 May 2015 15:38:33 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4L5cOJc14942458 for ; Thu, 21 May 2015 15:38:33 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4L5bxEN027571 for ; Thu, 21 May 2015 15:38:00 +1000 Date: Thu, 21 May 2015 11:07:38 +0530 From: Bharata B Rao Message-ID: <20150521053738.GA32383@in.ibm.com> References: <1432184528-31252-1-git-send-email-bharata@linux.vnet.ibm.com> <1432184528-31252-4-git-send-email-bharata@linux.vnet.ibm.com> <555D6CF0.9030001@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <555D6CF0.9030001@suse.de> Subject: Re: [Qemu-devel] [PATCH v3 3/3] ppc: Move cpu_exec_init() call to realize function Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: zhugh.fnst@cn.fujitsu.com, ehabkost@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, imammedo@redhat.com, david@gibson.dropbear.id.au On Thu, May 21, 2015 at 07:28:16AM +0200, Andreas Färber wrote: > Am 21.05.2015 um 07:02 schrieb Bharata B Rao: > > Move cpu_exec_init() call from instance_init to realize. This allows > > any failures from cpu_exec_init() to be handled appropriately. > > Also add corresponding cpu_exec_exit() call from unrealize. > > > > Signed-off-by: Bharata B Rao > > Reviewed-by: David Gibson > > --- > > target-ppc/translate_init.c | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > > index 52d95ce..2b72f2d 100644 > > --- a/target-ppc/translate_init.c > > +++ b/target-ppc/translate_init.c > > @@ -8928,6 +8928,11 @@ static void ppc_cpu_realizefn(DeviceState *dev, Error **errp) > > return; > > } > > > > + cpu_exec_init(&cpu->env, &local_err); > > + if (local_err != NULL) { > > + error_propagate(errp, local_err); > > + return; > > + } > > cpu->cpu_dt_id = (cs->cpu_index / smp_threads) * max_smt > > + (cs->cpu_index % smp_threads); > > #endif > > @@ -9141,6 +9146,8 @@ static void ppc_cpu_unrealizefn(DeviceState *dev, Error **errp) > > opc_handler_t **table; > > int i, j; > > > > + cpu_exec_exit(CPU(dev)); > > + > > for (i = 0; i < PPC_CPU_OPCODES_LEN; i++) { > > if (env->opcodes[i] == &invalid_handler) { > > continue; > > @@ -9633,8 +9640,6 @@ static void ppc_cpu_initfn(Object *obj) > > CPUPPCState *env = &cpu->env; > > > > cs->env_ptr = env; > > - cpu_exec_init(env, &error_abort); > > - cpu->cpu_dt_id = cs->cpu_index; > > Commit message talks about movements, but not about dropping cpu_dt_id > assignment - accidental or just missing an explanation? There is already code in realizefn of ppc cpu to deduce cpu_dt_id from cpu_index, so this default assignment here isn't necessary. Regards, Bharata.