From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvLfJ-0006Wx-Jr for qemu-devel@nongnu.org; Thu, 21 May 2015 04:17:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvLfE-0004A1-ON for qemu-devel@nongnu.org; Thu, 21 May 2015 04:17:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvLfE-00049q-H4 for qemu-devel@nongnu.org; Thu, 21 May 2015 04:17:12 -0400 Date: Thu, 21 May 2015 10:17:06 +0200 From: Igor Mammedov Message-ID: <20150521101706.4345fe65@nial.brq.redhat.com> In-Reply-To: <1432175331-12548-7-git-send-email-zhaoshenglong@huawei.com> References: <1432175331-12548-1-git-send-email-zhaoshenglong@huawei.com> <1432175331-12548-7-git-send-email-zhaoshenglong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 06/24] hw/acpi/aml-build: Add aml_interrupt() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, alex.bennee@linaro.org, hanjun.guo@linaro.org, pbonzini@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org, shannon.zhao@linaro.org On Thu, 21 May 2015 10:28:33 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Add aml_interrupt() for describing device interrupt in resource template. > These can be used to generating DSDT table for ACPI on ARM. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 27 +++++++++++++++++++++++++++ > include/hw/acpi/aml-build.h | 42 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 69 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index ad4d7ea..0d99941 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -533,6 +533,33 @@ Aml *aml_memory32_fixed(uint32_t addr, uint32_t size, > return var; > } > > +/* > + * ACPI 5.0: 6.4.3.6 Extended Interrupt Descriptor > + * Type 1, Large Item Name 0x9 > + */ > +Aml *aml_interrupt(AmlConsumerAndProducer con_and_pro, > + AmlLevelAndEdge level_and_edge, > + AmlActiveHighAndLow high_and_low, AmlShared shared, > + uint32_t irq) > +{ > + Aml *var = aml_alloc(); > + uint8_t irq_flags = con_and_pro | (level_and_edge << 1) > + | (high_and_low << 2) | (shared << 3); > + > + build_append_byte(var->buf, 0x89); /* Extended irq descriptor */ > + build_append_byte(var->buf, 6); /* Length, bits[7:0] minimum value = 6 */ > + build_append_byte(var->buf, 0); /* Length, bits[15:8] minimum value = 0 */ > + build_append_byte(var->buf, irq_flags); /* Interrupt Vector Information. */ > + build_append_byte(var->buf, 0x01); /* Interrupt table length = 1 */ > + > + /* Interrupt Number */ > + build_append_byte(var->buf, extract32(irq, 0, 8)); /* bits[7:0] */ > + build_append_byte(var->buf, extract32(irq, 8, 8)); /* bits[15:8] */ > + build_append_byte(var->buf, extract32(irq, 16, 8)); /* bits[23:16] */ > + build_append_byte(var->buf, extract32(irq, 24, 8)); /* bits[31:24] */ > + return var; > +} > + > /* ACPI 1.0b: 6.4.2.5 I/O Port Descriptor */ > Aml *aml_io(AmlIODecode dec, uint16_t min_base, uint16_t max_base, > uint8_t aln, uint8_t len) > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index bd0d9e7..df23479 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -111,6 +111,44 @@ typedef enum { > AML_READ_WRITE = 1, > } AmlReadAndWrite; > > +/* > + * ACPI 5.0: Table 6-187 Extended Interrupt Descriptor Definition > + * Interrupt Vector Flags Bits[0] Consumer/Producer > + */ > +typedef enum { > + AML_CONSUMER_PRODUCER = 0, > + AML_CONSUMER = 1, > +} AmlConsumerAndProducer; > + > +/* > + * ACPI 5.0: Table 6-187 Extended Interrupt Descriptor Definition > + * _HE field definition > + */ > +typedef enum { > + AML_LEVEL = 0, > + AML_EDGE = 1, > +} AmlLevelAndEdge; > + > +/* > + * ACPI 5.0: Table 6-187 Extended Interrupt Descriptor Definition > + * _LL field definition > + */ > +typedef enum { > + AML_ACTIVE_HIGH = 0, > + AML_ACTIVE_LOW = 1, > +} AmlActiveHighAndLow; > + > +/* > + * ACPI 5.0: Table 6-187 Extended Interrupt Descriptor Definition > + * _SHR field definition > + */ > +typedef enum { > + AML_EXCLUSIVE = 0, > + AML_SHARED = 1, > + AML_EXCLUSIVE_AND_WAKE = 2, > + AML_SHARED_AND_WAKE = 3, > +} AmlShared; > + > typedef > struct AcpiBuildTables { > GArray *table_data; > @@ -170,6 +208,10 @@ Aml *aml_call3(const char *method, Aml *arg1, Aml *arg2, Aml *arg3); > Aml *aml_call4(const char *method, Aml *arg1, Aml *arg2, Aml *arg3, Aml *arg4); > Aml *aml_memory32_fixed(uint32_t addr, uint32_t size, > AmlReadAndWrite read_and_write); > +Aml *aml_interrupt(AmlConsumerAndProducer con_and_pro, > + AmlLevelAndEdge level_and_edge, > + AmlActiveHighAndLow high_and_low, AmlShared shared, > + uint32_t irq); > Aml *aml_io(AmlIODecode dec, uint16_t min_base, uint16_t max_base, > uint8_t aln, uint8_t len); > Aml *aml_operation_region(const char *name, AmlRegionSpace rs,