From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvuKy-0005xL-4G for qemu-devel@nongnu.org; Fri, 22 May 2015 17:18:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvuKu-00078o-M4 for qemu-devel@nongnu.org; Fri, 22 May 2015 17:18:36 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvuKu-00078Y-GT for qemu-devel@nongnu.org; Fri, 22 May 2015 17:18:32 -0400 Date: Fri, 22 May 2015 14:18:30 -0700 From: Andrew Morton Message-Id: <20150522141830.f969b285ad072a23bb28f196@linux-foundation.org> In-Reply-To: <20150522204809.GB4251@redhat.com> References: <1431624680-20153-1-git-send-email-aarcange@redhat.com> <1431624680-20153-23-git-send-email-aarcange@redhat.com> <20150522131822.74f374dd5a75a0285577c714@linux-foundation.org> <20150522204809.GB4251@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 22/23] userfaultfd: avoid mmap_sem read recursion in mcopy_atomic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrea Arcangeli Cc: Hugh Dickins , zhang.zhanghailiang@huawei.com, kvm@vger.kernel.org, Pavel Emelyanov , linux-api@vger.kernel.org, Johannes Weiner , Dave Hansen , linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, linux-mm@kvack.org, Andres Lagar-Cavilla , Mel Gorman , Paolo Bonzini , "Kirill A. Shutemov" , "Huangpeng (Peter)" , Sanidhya Kashyap , Linus Torvalds , Andy Lutomirski , "Dr. David Alan Gilbert" , Peter Feiner There's a more serious failure with i386 allmodconfig: fs/userfaultfd.c:145:2: note: in expansion of macro 'BUILD_BUG_ON' BUILD_BUG_ON(sizeof(struct uffd_msg) != 32); I'm surprised the feature is even reachable on i386 builds?