From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47264)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Ywslz-0001Xs-Mr
	for qemu-devel@nongnu.org; Mon, 25 May 2015 09:50:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Ywslu-0003wp-Ii
	for qemu-devel@nongnu.org; Mon, 25 May 2015 09:50:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39519)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Ywslu-0003wh-C3
	for qemu-devel@nongnu.org; Mon, 25 May 2015 09:50:26 -0400
Date: Mon, 25 May 2015 15:50:16 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20150525155016.28288b15@nial.brq.redhat.com>
In-Reply-To: <1432538077-15712-1-git-send-email-zhaoshenglong@huawei.com>
References: <1432538077-15712-1-git-send-email-zhaoshenglong@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hw/acpi/aml-build: Fix memory leak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: shannon.zhao@linaro.org, qemu-devel@nongnu.org, mst@redhat.com

On Mon, 25 May 2015 15:14:37 +0800
Shannon Zhao <zhaoshenglong@huawei.com> wrote:

> From: Shannon Zhao <shannon.zhao@linaro.org>
> 
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  hw/acpi/aml-build.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 323b7bc..9efef70 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -306,6 +306,7 @@ static void aml_free(gpointer data, gpointer user_data)
>  {
>      Aml *var = data;
>      build_free_array(var->buf);
> +    g_free(var);
>  }
>  
>  Aml *init_aml_allocator(void)