From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41748)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christoffer.dall@linaro.org>) id 1YwzPM-0005yy-Ts
	for qemu-devel@nongnu.org; Mon, 25 May 2015 16:55:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <christoffer.dall@linaro.org>) id 1YwzPJ-0003Xd-P2
	for qemu-devel@nongnu.org; Mon, 25 May 2015 16:55:36 -0400
Received: from mail-lb0-f174.google.com ([209.85.217.174]:35828)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christoffer.dall@linaro.org>) id 1YwzPJ-0003XU-Fq
	for qemu-devel@nongnu.org; Mon, 25 May 2015 16:55:33 -0400
Received: by lbbuc2 with SMTP id uc2so57635733lbb.2
	for <qemu-devel@nongnu.org>; Mon, 25 May 2015 13:55:32 -0700 (PDT)
Date: Mon, 25 May 2015 22:56:00 +0200
From: Christoffer Dall <christoffer.dall@linaro.org>
Message-ID: <20150525205600.GA10659@cbox>
References: <1432464666-4825-1-git-send-email-christoffer.dall@linaro.org>
	<1432464666-4825-5-git-send-email-christoffer.dall@linaro.org>
	<011b01d096ec$1a395e80$4eac1b80$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <011b01d096ec$1a395e80$4eac1b80$@samsung.com>
Subject: Re: [Qemu-devel] [PATCH v3 4/4] target-arm: Add the GICv2m to the
 virt board
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: eric.auger@linaro.org, qemu-devel@nongnu.org, kvmarm@lists.cs.columbia.edu

Hi Pavel,

On Mon, May 25, 2015 at 04:09:58PM +0300, Pavel Fedin wrote:
>  Hello!
> 
> >  typedef struct MemMapEntry {
> > @@ -88,6 +90,7 @@ typedef struct VirtBoardInfo {
> >      int fdt_size;
> >      uint32_t clock_phandle;
> >      uint32_t gic_phandle;
> > +    uint32_t v2m_phandle;
> >  } VirtBoardInfo;
> 
>  Could you rename v2m_phandle to something more neutral like msi_phandle ? It will also be
> used by GICv3 ITS implementation.
> 
That's sort of how to speculate about.  Why can't those patches just
rename the variable then?  Right now, as the code stands, msi_phandle
would be less clear IMHO.

-Christoffer