From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx2vY-0007WJ-8I for qemu-devel@nongnu.org; Mon, 25 May 2015 20:41:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yx2vX-0000DR-4y for qemu-devel@nongnu.org; Mon, 25 May 2015 20:41:04 -0400 Date: Tue, 26 May 2015 10:34:26 +1000 From: David Gibson Message-ID: <20150526003426.GK6255@voom.redhat.com> References: <1432023962-32406-1-git-send-email-nikunj@linux.vnet.ibm.com> <1432023962-32406-4-git-send-email-nikunj@linux.vnet.ibm.com> <5561B074.9090207@ozlabs.ru> <87d21p8du8.fsf@abhimanyu.in.ibm.com> <5562F09F.3000808@ozlabs.ru> <871ti57y6f.fsf@abhimanyu.in.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Rex5+51txc1ort/q" Content-Disposition: inline In-Reply-To: <871ti57y6f.fsf@abhimanyu.in.ibm.com> Subject: Re: [Qemu-devel] [PATCH v5 3/4] spapr_pci: enumerate and add PCI device tree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania Cc: Alexey Kardashevskiy , mdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de --Rex5+51txc1ort/q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 25, 2015 at 03:53:52PM +0530, Nikunj A Dadhania wrote: > Alexey Kardashevskiy writes: > > On 05/25/2015 02:45 PM, Nikunj A Dadhania wrote: > >> Alexey Kardashevskiy writes: [snip] > >>> Can we also add a hack here to scan for the "qemu,phb-enumerated" str= ing in > >>> the SLOF bin image? > >> > >> Really ? That would be ugly. > > > > > > Well, chances that the binary image will have this line by accident are= zero. > > > > And I spent quite some time debugging SRIOV + VFIO when I realized that= =20 > > SLOF is old on the test machine where others used to debug too. It woul= d be=20 > > really nice to have a warning that something is wrong. May be extend=20 > > "client-architecture-support" somehow or have some release/date signatu= re=20 > > in known place in SLOF... Thomas (?) also asked for this :) >=20 > Sure, I can work on this. I would not recommend grepping though. Yeah, don't do this. The ugliness is not worth it. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Rex5+51txc1ort/q Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVY7+RAAoJEGw4ysog2bOS+jkP/R7qg/T5i6fSyh+fJ7VBs3Lr Rx0pTXAaPbekMvp1lOSyxHKrLrheIopS3ZRhspSu++GkouLLiSr8CD/Q3Ddhxvw8 G3/1siVDnNNaoJ/BNf4xjWlJZxIlttT9Ifns2mEXxi9su0io2TKFZyS2HZSQ+9MV Z4lulWo+67MMgZggFbzfRBDu8ufrUPO92yf6muoxHraGpkNcGkNyEUtiXa0kd8w0 GqTXSTHBluEMJK4ugEfCIQvM/nPshxZpNJKFcXbIOlA6hReDEp2b5HInRAedW47b hJS7fHL8Suei+/7hv9iDxpv0wov4yYEhicN4BfsvtmZl8cr8D2n/f3JfHaJm7tsV YmRyW/JnYf5gl2hOZgzSmPvtK11rIjUa+bOoDt/eHRmDMr1d6LuYhoqs2Fp3So44 wknW18Js1M/zxYBvt6QEThda+Y7OoP4M/Iq8zDAHu3Wl+VbQWDbLiVNZXbMcKnbe 26gOcyWkBqRYNeOqhl/174jHMptKfGng/2wlnC2P/TLrVVFAwuWNsXyZpYIREMFc p28WM2coviuHRdApdGcxJSo5lYQZm9TSvHd3Z5RTlkdWP6MWrS9zNH2uI6B/XeVZ O9m1YXRYbifjsPFzRUo2qGv8G7TzL2NOEhKfrXAaLV5bk3h5TnvtS633XSqP+IHX advDIZJuLzYpQuObPsxD =WTL7 -----END PGP SIGNATURE----- --Rex5+51txc1ort/q--