From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx3po-0006zO-PP for qemu-devel@nongnu.org; Mon, 25 May 2015 21:39:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yx3pk-0000Dd-LC for qemu-devel@nongnu.org; Mon, 25 May 2015 21:39:12 -0400 Date: Tue, 26 May 2015 11:23:12 +1000 From: David Gibson Message-ID: <20150526012312.GM6255@voom.redhat.com> References: <1430971024-27899-1-git-send-email-david@gibson.dropbear.id.au> <1430971024-27899-3-git-send-email-david@gibson.dropbear.id.au> <554AE64A.5050901@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sMkrXc3gAYLRVOjR" Content-Disposition: inline In-Reply-To: <554AE64A.5050901@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH 2/4] spapr: Remove obsolete ram_limit field from sPAPRMachineState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: lvivier@redhat.com, thuth@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, agraf@suse.de, qemu-ppc@nongnu.org, bharata@linux.vnet.ibm.com, afaerber@suse.de --sMkrXc3gAYLRVOjR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 07, 2015 at 02:12:58PM +1000, Alexey Kardashevskiy wrote: > On 05/07/2015 01:57 PM, David Gibson wrote: > >The ram_limit field was imported from sPAPREnvironment where it predates > >the machine's ram size being available generically from machine->ram_siz= e. > > > >Signed-off-by: David Gibson > >--- > > hw/ppc/spapr.c | 3 +-- > > hw/ppc/spapr_hcall.c | 3 ++- > > include/hw/ppc/spapr.h | 1 - > > 3 files changed, 3 insertions(+), 4 deletions(-) > > > >diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > >index 601c41b..1123358 100644 > >--- a/hw/ppc/spapr.c > >+++ b/hw/ppc/spapr.c > >@@ -1496,9 +1496,8 @@ static void ppc_spapr_init(MachineState *machine) > > } > > > > /* allocate RAM */ > >- sm->ram_limit =3D ram_size; >=20 >=20 >=20 > I had to look at the code to realize that ram_size is local and it can > actually be removed. Actually.. it's worse than that. There's both a global and this local which was masking it. Luckily the local had the same value, but it's still nasty. Respin will clean this up better. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --sMkrXc3gAYLRVOjR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVY8sAAAoJEGw4ysog2bOSPGUQANFRT9N/DAii7uAfxKZns20F r1K1j4LeiCtCo3m2Hu+TzAsiIPeBQtrX6cMS9HjDKkA502tunfjFEbqhVSdcyEFO X3XKCM/t8GDYJb9rBXcy7u+eICw3EwXj2w3peVCeFFhF8RXGNbo/L2hDmaLwjzSY mo+eJYv7n8NDJsw8WoGUVyDjnLshmNSmfx31leTXeM8CVmnYcWVwztAlHtuHebO3 XwH2+0yt+7OPwiS9yEimLHR5oh4HQ311XdaXccMz5QD8/UlwpIJO3ZV8km9MuVhb PuDGrxRcMR8imsBzAKN5w2+qZXij+rTcvLsIzmqGzkgfOwTjB0Mat62g4lh3oyKA M/WAwZ5DpNWTOmyK1PDU9IeZoKrwhbKy1ZeQlkendgN16SaR/mIgX6HZ1uVcKt89 jAN5U9arMlf0SctLYWm0hsc8pFul2PQFpSNXwFwB1wv6GnGFF+7uYx91WOWM10HW EhmNrL2ECoa0UOnpMj/ZJtoEBa1g4HpcNx3VqUdCvaeVg7FKPVr0LSC64cHvPNG/ 707j+Xt3ku27iHrCZJ3SR6/ful1bJMaH3dAPNHdUlhmKUAMyhm6lGespS6pnsBn2 qYPJc9tSHMkMH5c+Qs8iAFE8mHBWD1bxh/CKgtVSTP78o1iqxCLXlOQf2z63K3gg vTZoKOPc5pdEnqdRp3bN =1Mnn -----END PGP SIGNATURE----- --sMkrXc3gAYLRVOjR--