From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx4OB-000188-OS for qemu-devel@nongnu.org; Mon, 25 May 2015 22:14:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yx4O8-0001kz-ID for qemu-devel@nongnu.org; Mon, 25 May 2015 22:14:43 -0400 Date: Tue, 26 May 2015 11:39:33 +1000 From: David Gibson Message-ID: <20150526013933.GN6255@voom.redhat.com> References: <1430971024-27899-1-git-send-email-david@gibson.dropbear.id.au> <1430971024-27899-4-git-send-email-david@gibson.dropbear.id.au> <20150507045003.GW18380@in.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EqVOK5mkaJAMmtSx" Content-Disposition: inline In-Reply-To: <20150507045003.GW18380@in.ibm.com> Subject: Re: [Qemu-devel] [PATCH 3/4] spapr: Remove obsolete entry_point field from sPAPRMachineState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: lvivier@redhat.com, thuth@redhat.com, mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, qemu-ppc@nongnu.org, afaerber@suse.de --EqVOK5mkaJAMmtSx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 07, 2015 at 10:20:03AM +0530, Bharata B Rao wrote: > On Thu, May 07, 2015 at 01:57:03PM +1000, David Gibson wrote: > > The sPAPRMachineState structure includes an entry_point field containing > > the initial PC value for starting the machine, even though this always = has > > the value 0x100. > >=20 > > I think this is a hangover from very early versions which bypassed the > > firmware when using -kernel. In any case it has no function now, so re= move > > it. > >=20 > > Signed-off-by: David Gibson > > --- > > hw/ppc/spapr.c | 4 +--- > > include/hw/ppc/spapr.h | 2 +- > > 2 files changed, 2 insertions(+), 4 deletions(-) > >=20 > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > > index 1123358..c4c7a07 100644 > > --- a/hw/ppc/spapr.c > > +++ b/hw/ppc/spapr.c > > @@ -928,7 +928,7 @@ static void ppc_spapr_reset(void) > > first_ppc_cpu->env.gpr[3] =3D sm->fdt_addr; > > first_ppc_cpu->env.gpr[5] =3D 0; > > first_cpu->halted =3D 0; > > - first_ppc_cpu->env.nip =3D sm->entry_point; > > + first_ppc_cpu->env.nip =3D SPAPR_ENTRY_POINT; > >=20 > > } > >=20 > > @@ -1641,8 +1641,6 @@ static void ppc_spapr_init(MachineState *machine) > > } > > g_free(filename); > >=20 > > - sm->entry_point =3D 0x100; > > - > > /* FIXME: Should register thigs through the MachineState's qdev > > * interface, this is a legacy from the sPAPREnvironment structure > > * which predated MachineState but had a similar function */ > > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h > > index 9e7cf0f..108ff45 100644 > > --- a/include/hw/ppc/spapr.h > > +++ b/include/hw/ppc/spapr.h > > @@ -13,6 +13,7 @@ typedef struct sPAPRConfigureConnectorState sPAPRConf= igureConnectorState; > > typedef struct sPAPREventLogEntry sPAPREventLogEntry; > >=20 > > #define HPTE64_V_HPTE_DIRTY 0x0000000000000040ULL > > +#define SPAPR_ENTRY_POINT 0x100 >=20 > checkpatch.pl complains about the use of tab here. Thanks, fixed. > Other than that I did a quick compile and VM boot test, things look ok. >=20 > Regards, > Bharata. >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --EqVOK5mkaJAMmtSx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVY87VAAoJEGw4ysog2bOSM3MQAN0a45ZoweNhyTukN/i87cLf 31UqL14AZ63wwYneykajyie2fQrR33xkD1ecXMpiW8RmRYzCl0466EXyvIxzauZV CGZ5PmMCNLpKf+wDCNkVgZxcWIulgtFqWafF2TAGJtuekmcTiYJC1I25IX5y/HpN /sOxRaagQXQ10uAtmHiKotVV4/1v7z9ZNwTpjRCH6Q04Fnr1sbfqB98vlONmjUbC FhZx9w/NuJn3ENYy/rkctP1C7xkKTH50iWpyvtv6VNBx4hmAXK5qgfu5dWY+pMfD DzEmqUTDQOL8rLq+KPMbzIR4tjVJe2imLtWKs4tHAF2XmFLExoDKlUudYmzMSOoD PC6F/J1ijXEf6tz/VI32UP8YKbgUG311Q+CaU384u7x8vEKDnxhRGCDXtL+BexCc HEpWJmMatrrGS3onh1TO5JvTbdjIEsrRWCExnjdHWEJrdqhK0ck84v8qoMygLD5n qxStqEsPqkBYf5onO8+jSYlBDZ0XB1ek0d4nF/SQjBEUcRydWdQF70V0n0Cvtelm j7XB5h4iCoPqD0uXBgxa1FvJXmjBTV8ADv+nYA6z8CTKvqq6Z6r0HTr7WWXdNJw+ c+TyR7KdsZhR6+iTUH5zElmJoE1yvVC9u/k79NPYfnAKKFp/f991iwfTH9/NjhAo ayDyb1GV0BhJ+8L2vWaQ =DZol -----END PGP SIGNATURE----- --EqVOK5mkaJAMmtSx--