From: David Gibson <david@gibson.dropbear.id.au>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Alexey Kardashevskiy" <aik@ozlabs.ru>,
"Alexander Graf" <agraf@suse.de>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] configure: Check for libfdt version 1.4.0
Date: Tue, 26 May 2015 12:57:40 +1000 [thread overview]
Message-ID: <20150526025740.GB30620@voom.redhat.com> (raw)
In-Reply-To: <CAFEAcA-MA70G5wH0qbn2Bi3ozdCm4KWSZXvSnxUq1+2U-RFmDA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]
On Mon, May 25, 2015 at 01:30:11PM +0100, Peter Maydell wrote:
> On 25 May 2015 at 02:35, David Gibson <david@gibson.dropbear.id.au> wrote:
> > On Mon, May 18, 2015 at 09:43:21AM +0200, Thomas Huth wrote:
> >> Some recent patches require functions from libfdt version 1.4.0,
> >> so we should check for this version during the configure step
> >> already. Unfortunately, there does not seem to be a proper #define
> >> for the version number in the libfdt headers. So alternatively, we
> >> check for the availability of the fdtXX_t types instead which have
> >> just been introduced with version 1.4.0.
> >
> > Um.. I'm confused by this. As far as I can recall the fdtXX_t types
> > have been in libfdt since.. well, forever, basically.
>
> There's no such typedef in the libfdt that QEMU is currently
> using (which I think is 1.3.0). It looks like they were added
> in this commit:
> https://git.kernel.org/cgit/utils/dtc/dtc.git/commit/libfdt/libfdt_env.h?id=feafcd972cb744750a65728440c99526e6199a6d
> in early 2013.
Ah, duh, I was mixing up the fdtXX_t _types_ which were introduced
with sparse annotations with the fdtXX_to_cpu functions/macros which
have been around since forever.
Still, I think looking at the actual exported functions is a better
idea than looking at the types - which I see Thomas has already done
in his latest spin.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-05-26 2:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 7:43 [Qemu-devel] [PATCH] configure: Check for libfdt version 1.4.0 Thomas Huth
2015-05-25 1:35 ` David Gibson
2015-05-25 12:30 ` Peter Maydell
2015-05-26 2:57 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526025740.GB30620@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).