From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx53f-0004gm-0T for qemu-devel@nongnu.org; Mon, 25 May 2015 22:57:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yx53e-0006hh-0u for qemu-devel@nongnu.org; Mon, 25 May 2015 22:57:34 -0400 Date: Tue, 26 May 2015 12:57:40 +1000 From: David Gibson Message-ID: <20150526025740.GB30620@voom.redhat.com> References: <1431935001-15678-1-git-send-email-thuth@redhat.com> <20150525013519.GH6255@voom.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="U+BazGySraz5kW0T" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] configure: Check for libfdt version 1.4.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Thomas Huth , Michael Roth , Alexey Kardashevskiy , Alexander Graf , QEMU Developers , "qemu-ppc@nongnu.org" , Andreas =?iso-8859-1?Q?F=E4rber?= --U+BazGySraz5kW0T Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 25, 2015 at 01:30:11PM +0100, Peter Maydell wrote: > On 25 May 2015 at 02:35, David Gibson wrote: > > On Mon, May 18, 2015 at 09:43:21AM +0200, Thomas Huth wrote: > >> Some recent patches require functions from libfdt version 1.4.0, > >> so we should check for this version during the configure step > >> already. Unfortunately, there does not seem to be a proper #define > >> for the version number in the libfdt headers. So alternatively, we > >> check for the availability of the fdtXX_t types instead which have > >> just been introduced with version 1.4.0. > > > > Um.. I'm confused by this. As far as I can recall the fdtXX_t types > > have been in libfdt since.. well, forever, basically. >=20 > There's no such typedef in the libfdt that QEMU is currently > using (which I think is 1.3.0). It looks like they were added > in this commit: > https://git.kernel.org/cgit/utils/dtc/dtc.git/commit/libfdt/libfdt_env.h?= id=3Dfeafcd972cb744750a65728440c99526e6199a6d > in early 2013. Ah, duh, I was mixing up the fdtXX_t _types_ which were introduced with sparse annotations with the fdtXX_to_cpu functions/macros which have been around since forever. Still, I think looking at the actual exported functions is a better idea than looking at the types - which I see Thomas has already done in his latest spin. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --U+BazGySraz5kW0T Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVY+EkAAoJEGw4ysog2bOSagUP/2iJV0ykLxBKfwM8jyaOC0zu JfkUb/ICF+ci/nJrZrTk65aPIUP9ehO5tzeQHd88PUcZkQz5/WccK7iCfJkBLEeo gVnY7ihA9AejoPiBuhEbwiKU6G3Eu5csAxn9NxoZih6GTz5unQc7TIeNPRbo80ko jlSWQ9ucapbkBtbvslNgYgfYLWqENP4FPfrgdiKSYW+D4laMpO6WQz75TR8uTI9m ++dQO+YanTfeNC4mg71cFucSTK/7fnbF75CA2Os5T+fTKqP6p8X+BZoG2+o18s11 OHyFbCwCA1NzVSTl3LdrMx0KZzwtqyu1l07VxZQzYP6z/xu/VEsIVBj3LF/ztssw wI29f2xp5YVHSI1hcl7B7S/cIU/VnbMBc86iicEXQHt4zbEPij/WwEn/tWJJLrVC LGfSu8l8onc+wltKgEsWUj+ZrR/cEJENGqBSPw1stV1V+sox5X7Pd5ud0H3kG1vr HhxEmqEKxoLKrlhAlHTDMSZhjkWQ7CtRj1t0pqpH962QwQXzTo6e04A9IPEJlcAi x5Fb+QLjg2f8VqaCzxZqBLhZ8k/Qa0t/kaDbpA2za5UkXWrwhSmGtyvnTXslneaF klTry6BXFdJaMcBYb4JEI3GR3FlnlvYnrmNLOB4BatCBYOliEJpX6yOb8VhOuQGf oHfo3ryGkL8mQXHtvx4p =gONc -----END PGP SIGNATURE----- --U+BazGySraz5kW0T--