From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57771) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx9QC-0004hA-5j for qemu-devel@nongnu.org; Tue, 26 May 2015 03:37:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yx9Q7-0002NW-6Z for qemu-devel@nongnu.org; Tue, 26 May 2015 03:37:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx9Q7-0002NQ-26 for qemu-devel@nongnu.org; Tue, 26 May 2015 03:37:03 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 9BBE22BB382 for ; Tue, 26 May 2015 07:37:02 +0000 (UTC) Date: Tue, 26 May 2015 15:36:57 +0800 From: Fam Zheng Message-ID: <20150526073657.GE13749@ad.nay.redhat.com> References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com> <1430152117-100558-5-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430152117-100558-5-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 04/29] display: add memory_region_sync_dirty_bitmap calls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On Mon, 04/27 18:28, Paolo Bonzini wrote: > diff --git a/hw/display/tcx.c b/hw/display/tcx.c > index 58faa96..2eb5aef 100644 > --- a/hw/display/tcx.c > +++ b/hw/display/tcx.c > @@ -353,6 +353,7 @@ static void tcx_update_display(void *opaque) > return; > } > > + memory_region_sync_dirty_bitmap(&ts->vram_mem); > for (y = 0; y < ts->height; page += TARGET_PAGE_SIZE) { > if (memory_region_get_dirty(&ts->vram_mem, page, TARGET_PAGE_SIZE, > DIRTY_MEMORY_VGA)) { Why not change tcx24_update_display as well? Fam