From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx9pO-0000jj-Qv for qemu-devel@nongnu.org; Tue, 26 May 2015 04:03:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yx9pL-0002MT-LP for qemu-devel@nongnu.org; Tue, 26 May 2015 04:03:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx9pL-0002MN-G5 for qemu-devel@nongnu.org; Tue, 26 May 2015 04:03:07 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 266B08E3CE for ; Tue, 26 May 2015 08:03:07 +0000 (UTC) Date: Tue, 26 May 2015 16:03:04 +0800 From: Fam Zheng Message-ID: <20150526080304.GI13749@ad.nay.redhat.com> References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com> <1430152117-100558-9-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430152117-100558-9-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 08/29] ui/console: remove dpy_gfx_update_dirty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On Mon, 04/27 18:28, Paolo Bonzini wrote: > dpy_gfx_update_dirty expects DIRTY_MEMORY_VGA logging to be always on, > but that will not be the case soon. Because it computes the memory > region on the fly for every update (with memory_region_find), it cannot > enable/disable logging by itself. > > We could always treat updates as invalidations if dirty logging is > not enabled, assuming that the board will enable logging on the > RAM region that includes the framebuffer. > > However, the function is unused, so just drop it. > > Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng