From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxA8B-00084O-FO for qemu-devel@nongnu.org; Tue, 26 May 2015 04:22:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxA88-0001CW-8z for qemu-devel@nongnu.org; Tue, 26 May 2015 04:22:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxA88-0001Bv-2d for qemu-devel@nongnu.org; Tue, 26 May 2015 04:22:32 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4Q8MVha022127 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 26 May 2015 04:22:31 -0400 Date: Tue, 26 May 2015 16:22:28 +0800 From: Fam Zheng Message-ID: <20150526082228.GA24238@ad.nay.redhat.com> References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com> <1430152117-100558-11-git-send-email-pbonzini@redhat.com> <20150526081040.GK13749@ad.nay.redhat.com> <55642BEA.4020908@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55642BEA.4020908@redhat.com> Subject: Re: [Qemu-devel] [PATCH 10/29] kvm: accept non-mapped memory in kvm_dirty_pages_log_change List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On Tue, 05/26 10:16, Paolo Bonzini wrote: > > > On 26/05/2015 10:10, Fam Zheng wrote: > > > It is okay if memory is not mapped into the guest but has dirty logging > > > enabled. When this happens, KVM will not do anything and only accesses > > > from the host will be logged. > > > > > > Signed-off-by: Paolo Bonzini > > > > Could you explain where this change is needed? > > I received a report of this error, obtained via iofuzz. Good to know. (maybe squash into the commit message?) Reviewed-by: Fam Zheng