From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53819)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YxB48-0004nm-Aa
	for qemu-devel@nongnu.org; Tue, 26 May 2015 05:22:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YxB43-0007S2-Cm
	for qemu-devel@nongnu.org; Tue, 26 May 2015 05:22:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49061)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YxB43-0007Rr-67
	for qemu-devel@nongnu.org; Tue, 26 May 2015 05:22:23 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4Q9MM5O022411
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Tue, 26 May 2015 05:22:22 -0400
Date: Tue, 26 May 2015 17:22:19 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150526092219.GA27391@ad.nay.redhat.com>
References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com>
	<1430152117-100558-12-git-send-email-pbonzini@redhat.com>
	<20150526084031.GL13749@ad.nay.redhat.com>
	<556437B9.1060600@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <556437B9.1060600@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 11/29] memory: include
 DIRTY_MEMORY_MIGRATION in the dirty log mask
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com

On Tue, 05/26 11:07, Paolo Bonzini wrote:
> 
> 
> On 26/05/2015 10:40, Fam Zheng wrote:
> > > @@ -1329,7 +1329,11 @@ bool memory_region_is_skip_dump(MemoryRegion *mr)
> > >  
> > >  uint8_t memory_region_get_dirty_log_mask(MemoryRegion *mr)
> > >  {
> > > -    return mr->dirty_log_mask;
> > > +    uint8_t mask = mr->dirty_log_mask;
> > > +    if (global_dirty_log) {
> > > +        mask |= (1 << DIRTY_MEMORY_MIGRATION);
> > 
> > This is ugly, but I don't know how to do differently. :(
> 
> Why do you think it's ugly?
> As long as the log_start/log_stop callbacks
> are handled properly, I think it's okay.

Ugly in the per object function relying on a global to propogate the new value.

Fam