Re: [Qemu-devel] [PATCH RFC 1/1] virtio: move host_features

[Cornelia Huck <cornelia.huck@de.ibm.com>]

On Tue, 26 May 2015 14:58:02 +0800
Shannon Zhao <zhaoshenglong@huawei.com> wrote:

> 
> 
> On 2015/5/22 20:11, Cornelia Huck wrote:
> > Move host_features from the individual transport proxies into
> > the virtio device. Transports may continue to add feature bits
> > during device plugging.
> > 
> > This should it make easier to offer different sets of host features
> > for virtio-1/transitional support.
> > 
> > Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> 
> Test virtio-mmio and virtio-pci. The host_features are same with/without
> this patch. There is a small comment on this below.
> 
> Tested-by: Shannon Zhao <shannon.zhao@linaro.org>
> 
> > ---
> >  hw/s390x/s390-virtio-bus.c     | 18 ++----------------
> >  hw/s390x/virtio-ccw.c          | 29 ++++++-----------------------
> >  hw/s390x/virtio-ccw.h          |  4 ----
> >  hw/virtio/virtio-bus.c         | 18 +++++-------------
> >  hw/virtio/virtio-mmio.c        | 22 +++-------------------
> >  hw/virtio/virtio-pci.c         | 17 ++++-------------
> >  hw/virtio/virtio.c             | 17 +++++++++--------
> >  include/hw/virtio/virtio-bus.h |  1 -
> >  include/hw/virtio/virtio.h     |  1 +
> >  9 files changed, 30 insertions(+), 97 deletions(-)

> > diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c
> > index 10123f3..1817a07 100644
> > --- a/hw/virtio/virtio-mmio.c
> > +++ b/hw/virtio/virtio-mmio.c
> > @@ -80,7 +80,6 @@ typedef struct {
> >      SysBusDevice parent_obj;
> >      MemoryRegion iomem;
> >      qemu_irq irq;
> > -    uint32_t host_features;
> 
> Maybe we should delete host_features in PCI and s390 as well.

I thought I did, but probably missed them.

> 
> >      /* Guest accessible state needing migration and reset */
> >      uint32_t host_features_sel;
> >      uint32_t guest_features_sel;

Thanks for looking at this patch.