From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx9YT-00005E-IL for qemu-devel@nongnu.org; Tue, 26 May 2015 03:45:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yx9YQ-0005FM-7S for qemu-devel@nongnu.org; Tue, 26 May 2015 03:45:41 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:53928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx9YP-0005F5-IO for qemu-devel@nongnu.org; Tue, 26 May 2015 03:45:38 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 26 May 2015 08:45:34 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6A85717D8069 for ; Tue, 26 May 2015 08:46:26 +0100 (BST) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4Q7jVXl24444954 for ; Tue, 26 May 2015 07:45:31 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4Q7jV4p009792 for ; Tue, 26 May 2015 01:45:31 -0600 Date: Tue, 26 May 2015 09:45:27 +0200 From: Cornelia Huck Message-ID: <20150526094527.72ff1ce4.cornelia.huck@de.ibm.com> In-Reply-To: <5564197A.4060803@huawei.com> References: <1432296715-12576-1-git-send-email-cornelia.huck@de.ibm.com> <1432296715-12576-2-git-send-email-cornelia.huck@de.ibm.com> <5564197A.4060803@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 1/1] virtio: move host_features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao Cc: qemu-devel@nongnu.org, mst@redhat.com On Tue, 26 May 2015 14:58:02 +0800 Shannon Zhao wrote: > > > On 2015/5/22 20:11, Cornelia Huck wrote: > > Move host_features from the individual transport proxies into > > the virtio device. Transports may continue to add feature bits > > during device plugging. > > > > This should it make easier to offer different sets of host features > > for virtio-1/transitional support. > > > > Signed-off-by: Cornelia Huck > > Test virtio-mmio and virtio-pci. The host_features are same with/without > this patch. There is a small comment on this below. > > Tested-by: Shannon Zhao > > > --- > > hw/s390x/s390-virtio-bus.c | 18 ++---------------- > > hw/s390x/virtio-ccw.c | 29 ++++++----------------------- > > hw/s390x/virtio-ccw.h | 4 ---- > > hw/virtio/virtio-bus.c | 18 +++++------------- > > hw/virtio/virtio-mmio.c | 22 +++------------------- > > hw/virtio/virtio-pci.c | 17 ++++------------- > > hw/virtio/virtio.c | 17 +++++++++-------- > > include/hw/virtio/virtio-bus.h | 1 - > > include/hw/virtio/virtio.h | 1 + > > 9 files changed, 30 insertions(+), 97 deletions(-) > > diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c > > index 10123f3..1817a07 100644 > > --- a/hw/virtio/virtio-mmio.c > > +++ b/hw/virtio/virtio-mmio.c > > @@ -80,7 +80,6 @@ typedef struct { > > SysBusDevice parent_obj; > > MemoryRegion iomem; > > qemu_irq irq; > > - uint32_t host_features; > > Maybe we should delete host_features in PCI and s390 as well. I thought I did, but probably missed them. > > > /* Guest accessible state needing migration and reset */ > > uint32_t host_features_sel; > > uint32_t guest_features_sel; Thanks for looking at this patch.