From: Stefan Hajnoczi <stefanha@gmail.com>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: hangaohuai@huawei.com, shannon.zhao@linaro.org,
qemu-devel@nongnu.org, stefanha@redhat.com,
peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [RFC PATCH] net/net: Record usage status of mac address
Date: Tue, 26 May 2015 11:08:12 +0100 [thread overview]
Message-ID: <20150526100812.GE13262@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1432201488-3832-1-git-send-email-zhaoshenglong@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]
On Thu, May 21, 2015 at 05:44:48PM +0800, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> Currently QEMU dynamically generates mac address for the NIC which
> doesn't specify the mac address. But when we hotplug a NIC without
> specifying mac address, the mac address will increase for the same NIC
> along with hotplug and hot-unplug, and at last it will overflow. And if
> we codeplug one NIC with mac address e.g. "52:54:00:12:34:56", then
> hotplug one NIC without specifying mac address and the mac address of
> the hotplugged NIC is duplicate of "52:54:00:12:34:56".
>
> This patch add a mac_table to record the usage status and free the mac
> address when the NIC is unrealized.
>
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> net/net.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++++----
> 1 file changed, 55 insertions(+), 4 deletions(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-05-26 10:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 9:44 [Qemu-devel] [RFC PATCH] net/net: Record usage status of mac address Shannon Zhao
2015-05-26 10:08 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526100812.GE13262@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=hangaohuai@huawei.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=stefanha@redhat.com \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).