From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50991)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YxD5D-0007ap-K6
	for qemu-devel@nongnu.org; Tue, 26 May 2015 07:31:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YxD5A-0001Ui-F3
	for qemu-devel@nongnu.org; Tue, 26 May 2015 07:31:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50044)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YxD5A-0001UX-7l
	for qemu-devel@nongnu.org; Tue, 26 May 2015 07:31:40 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4QBVdFL014322
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Tue, 26 May 2015 07:31:39 -0400
Date: Tue, 26 May 2015 19:31:37 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150526113137.GT13749@ad.nay.redhat.com>
References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com>
	<1430152117-100558-22-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1430152117-100558-22-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 21/29] exec: only check relevant bitmaps
	for cleanliness
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com

On Mon, 04/27 18:28, Paolo Bonzini wrote:
> Most of the time, not all bitmaps have to be marked as dirty;
> do not do anything if the interesting ones are already dirty.
> Previously, any clean bitmap would have cause all the bitmaps to be
> marked dirty.
> 
> In fact, unless running TCG most of the time bitmap operations need
> not be done at all, because memory_region_is_logging returns zero.
> In this case, skip the call to cpu_physical_memory_range_includes_clean
> altogether as well.
> 
> With this patch, cpu_physical_memory_set_dirty_range is called
> unconditionally, so there need not be anymore a separate call to
> xen_modified_memory.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Fam Zheng <famz@redhat.com>