From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxELZ-0002bu-Cx for qemu-devel@nongnu.org; Tue, 26 May 2015 08:52:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxELY-0004dQ-Fo for qemu-devel@nongnu.org; Tue, 26 May 2015 08:52:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxELY-0004dI-B2 for qemu-devel@nongnu.org; Tue, 26 May 2015 08:52:40 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 44EBF56 for ; Tue, 26 May 2015 12:52:39 +0000 (UTC) Date: Tue, 26 May 2015 13:52:35 +0100 From: Stefan Hajnoczi Message-ID: <20150526125235.GJ13262@stefanha-thinkpad.redhat.com> References: <1432322539-23719-1-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tKy6e3LXpfmanBFM" Content-Disposition: inline In-Reply-To: <1432322539-23719-1-git-send-email-thuth@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too, List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Jason Wang , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Markus Armbruster --tKy6e3LXpfmanBFM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 22, 2015 at 09:22:19PM +0200, Thomas Huth wrote: > So far, it is not possible to use the network dump interface > with the "-netdev" option yet, it only works with the legacy > "-net" option. To be able to use it with "-netdev", too, this > patch now enables the "vlan" packet distribution for the > "-netdev" option, too, so that you can now dump network packets > like this: >=20 > qemu... -device e1000,netdev=3Dmyhub -netdev hubport,hubid=3D1,id=3Dmyhub= \ > -netdev user,id=3Dn1,vlan=3D1,tftp=3D/tmp/tftp,bootfile=3DzImage \ > -netdev dump,id=3Dn2,vlan=3D1,file=3D/tmp/dump.dat >=20 > Signed-off-by: Thomas Huth > --- > net/net.c | 3 +++ > qapi-schema.json | 1 + > 2 files changed, 4 insertions(+) >=20 > [Note: I'm quite new to this area of the code, please review carefully > whether this approach makes sense or whether it should be done differen= tly] We thought the QEMU "vlan" concept would be dropped completely in the future, so it was never added to -netdev. No patches to do that have been posted over the years, so I think it was more of a conceptual goal than a concrete requirement. I'm okay with merging this but will leave some time for discussion before merging the patch. "Speak now or forever hold your peace" Stefan --tKy6e3LXpfmanBFM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVZGyTAAoJEJykq7OBq3PIuYAIAME+H7Zq3+CrnGCi6U1dq6OQ pg5vYAZOZWAJHbVaqjoh5rwqj1uZXk1gzaimxHqX8GJQS07b0hcg5LtFQD07kJf2 B5tpivvuqUlgRE8h1PuQnG6mBnyuPL3RykuLw2ZNHWT0rde3kTiiph95OsBot5pF QjlaZrxh980SNN1qRNVVGembYZz7TzzsCj/ky037CjGXZ16yCAASbSPu4hOHbgfg D0tRiMEKh4rEfEhBS1Zv8/DmxIwN2njL8Zqd16TmYnWXkgi1EuENp4hJVtVsSTUX qpwmsTgdWugZMcV1BbVZhRLj9M7BfcNVs0sAQDiBUjGnyH/F7KC6c6qAUET/fBE= =L6sY -----END PGP SIGNATURE----- --tKy6e3LXpfmanBFM--