qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: lcapitulino@redhat.com, Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI
Date: Tue, 26 May 2015 13:52:41 +0100	[thread overview]
Message-ID: <20150526125241.GA30049@redhat.com> (raw)
In-Reply-To: <1432644705.24602.8.camel@nilsson.home.kraxel.org>

On Tue, May 26, 2015 at 02:51:45PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > >> +#
> > >> +# Set the spice/vnc connection info for the migration target.  The
> > >> +# spice/vnc server will ask the spice/vnc client to automatically
> > >> +# reconnect using the new parameters (if specified) once the vm
> > >> +# migration finished successfully.  Not yet implemented for VNC.
> > >> +#
> > >> +# @protocol:     must be "spice"
> > >> +# @hostname:     migration target hostname
> > >> +# @port:         #optional spice/vnc tcp port for plaintext channels
> > >
> > > Is it worth documenting vnc, when we just stated earlier that protocol
> > > must be spice?
> > 
> > I think this is a question for Gerd (cc'ed).
> 
> IIRC Daniel (added to Cc:) had plans to create a vnc extension for that.
> 
> Which was the reason to explicitly add the protocol here, so we can use
> the same command for both spice and vnc some day.

Yeah, it would be nice to do a VNC extension, though realistically I'm
not going to have time for that anytime in the forseeable future.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

  reply	other threads:[~2015-05-26 12:52 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 11:36 [Qemu-devel] [PATCH 00/20] monitor: Wean core off QError, and other cleanups Markus Armbruster
2015-05-22 11:36 ` [Qemu-devel] [PATCH 01/20] monitor: Drop broken, unused asynchronous command interface Markus Armbruster
2015-05-22 21:14   ` Eric Blake
2015-05-26  9:00     ` Markus Armbruster
2015-05-22 11:36 ` [Qemu-devel] [PATCH 02/20] monitor: Clean up after previous commit Markus Armbruster
2015-05-22 21:19   ` Eric Blake
2015-05-26  9:01     ` Markus Armbruster
2015-05-22 11:36 ` [Qemu-devel] [PATCH 03/20] monitor: Improve and document client_migrate_info protocol error Markus Armbruster
2015-05-22 21:21   ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI Markus Armbruster
2015-05-22 21:43   ` Eric Blake
2015-05-26  9:16     ` Markus Armbruster
2015-05-26 12:51       ` Gerd Hoffmann
2015-05-26 12:52         ` Daniel P. Berrange [this message]
2015-05-26 14:12           ` Markus Armbruster
2015-05-26 14:15             ` Gerd Hoffmann
2015-05-26 14:55               ` Markus Armbruster
2015-05-22 11:36 ` [Qemu-devel] [PATCH 05/20] monitor: Use traditional command interface for HMP drive_del Markus Armbruster
2015-05-22 21:47   ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 06/20] monitor: Use traditional command interface for HMP device_add Markus Armbruster
2015-05-22 21:56   ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 07/20] monitor: Use trad. command interface for HMP pcie_aer_inject_error Markus Armbruster
2015-05-22 22:05   ` Eric Blake
2015-05-26  9:25     ` Markus Armbruster
2015-05-26 13:01       ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 08/20] monitor: Drop unused "new" HMP command interface Markus Armbruster
2015-05-22 22:10   ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 09/20] monitor: Propagate errors through qmp_check_client_args() Markus Armbruster
2015-05-22 22:19   ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 10/20] monitor: Propagate errors through qmp_check_input_obj() Markus Armbruster
2015-05-22 22:20   ` Eric Blake
2015-05-26  9:27     ` Markus Armbruster
2015-05-22 11:36 ` [Qemu-devel] [PATCH 11/20] monitor: Wean monitor_protocol_emitter() off mon->error Markus Armbruster
2015-05-22 22:22   ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 12/20] monitor: Inline monitor_has_error() into its only caller Markus Armbruster
2015-05-22 22:23   ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 13/20] monitor: Limit QError use to command handlers Markus Armbruster
2015-05-22 22:38   ` Eric Blake
2015-05-26  9:45     ` Markus Armbruster
2015-05-22 11:36 ` [Qemu-devel] [PATCH 14/20] monitor: Rename handle_user_command() to handle_hmp_command() Markus Armbruster
2015-05-22 22:43   ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 15/20] monitor: Rename monitor_control_read(), monitor_control_event() Markus Armbruster
2015-05-22 22:46   ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 16/20] monitor: Unbox Monitor member mc and rename to qmp Markus Armbruster
2015-05-22 22:52   ` Eric Blake
2015-05-26  9:48     ` Markus Armbruster
2015-05-22 11:36 ` [Qemu-devel] [PATCH 17/20] monitor: Drop do_qmp_capabilities()'s superfluous QMP check Markus Armbruster
2015-05-22 22:53   ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 18/20] monitor: Turn int command_mode into bool in_command_mode Markus Armbruster
2015-05-22 22:56   ` Eric Blake
2015-05-26  9:49     ` Markus Armbruster
2015-05-22 11:36 ` [Qemu-devel] [PATCH 19/20] monitor: Rename monitor_ctrl_mode() to monitor_is_qmp() Markus Armbruster
2015-05-22 22:59   ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 20/20] monitor: Change return type of monitor_cur_is_qmp() to bool Markus Armbruster
2015-05-22 23:00   ` Eric Blake
2015-05-26  9:49     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150526125241.GA30049@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).