From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxELj-0002tK-3S for qemu-devel@nongnu.org; Tue, 26 May 2015 08:52:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxELf-0004f3-15 for qemu-devel@nongnu.org; Tue, 26 May 2015 08:52:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxELe-0004er-ST for qemu-devel@nongnu.org; Tue, 26 May 2015 08:52:46 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id CF62AC6569 for ; Tue, 26 May 2015 12:52:45 +0000 (UTC) Date: Tue, 26 May 2015 13:52:41 +0100 From: "Daniel P. Berrange" Message-ID: <20150526125241.GA30049@redhat.com> References: <1432294585-5984-1-git-send-email-armbru@redhat.com> <1432294585-5984-5-git-send-email-armbru@redhat.com> <555FA2E4.2000409@redhat.com> <87iobfem19.fsf@blackfin.pond.sub.org> <1432644705.24602.8.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1432644705.24602.8.camel@nilsson.home.kraxel.org> Subject: Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: lcapitulino@redhat.com, Markus Armbruster , qemu-devel@nongnu.org On Tue, May 26, 2015 at 02:51:45PM +0200, Gerd Hoffmann wrote: > Hi, > > > >> +# > > >> +# Set the spice/vnc connection info for the migration target. The > > >> +# spice/vnc server will ask the spice/vnc client to automatically > > >> +# reconnect using the new parameters (if specified) once the vm > > >> +# migration finished successfully. Not yet implemented for VNC. > > >> +# > > >> +# @protocol: must be "spice" > > >> +# @hostname: migration target hostname > > >> +# @port: #optional spice/vnc tcp port for plaintext channels > > > > > > Is it worth documenting vnc, when we just stated earlier that protocol > > > must be spice? > > > > I think this is a question for Gerd (cc'ed). > > IIRC Daniel (added to Cc:) had plans to create a vnc extension for that. > > Which was the reason to explicitly add the protocol here, so we can use > the same command for both spice and vnc some day. Yeah, it would be nice to do a VNC extension, though realistically I'm not going to have time for that anytime in the forseeable future. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|