From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53480)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YxEMK-0003zf-Er
	for qemu-devel@nongnu.org; Tue, 26 May 2015 08:53:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YxEMG-0004qQ-KT
	for qemu-devel@nongnu.org; Tue, 26 May 2015 08:53:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52870)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YxEMG-0004qJ-DS
	for qemu-devel@nongnu.org; Tue, 26 May 2015 08:53:24 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4QCrNMu030783
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Tue, 26 May 2015 08:53:23 -0400
Date: Tue, 26 May 2015 20:53:21 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150526125321.GC21680@ad.nay.redhat.com>
References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com>
	<1430152117-100558-3-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1430152117-100558-3-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 02/29] g364fb: remove pointless call to
 memory_region_set_coalescing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com

On Mon, 04/27 18:28, Paolo Bonzini wrote:
> Coalescing work on MMIO, not RAM, thus this call has no effect.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Fam Zheng <famz@redhat.com>

> ---
>  hw/display/g364fb.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c
> index 46f7b41..6543f2f 100644
> --- a/hw/display/g364fb.c
> +++ b/hw/display/g364fb.c
> @@ -489,7 +489,6 @@ static void g364fb_init(DeviceState *dev, G364State *s)
>      memory_region_init_ram_ptr(&s->mem_vram, NULL, "vram",
>                                 s->vram_size, s->vram);
>      vmstate_register_ram(&s->mem_vram, dev);
> -    memory_region_set_coalescing(&s->mem_vram);
>  }
>  
>  #define TYPE_G364 "sysbus-g364"
> -- 
> 1.8.3.1
> 
>