From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxEOx-0008V9-Q4 for qemu-devel@nongnu.org; Tue, 26 May 2015 08:56:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxEOt-0005n2-QA for qemu-devel@nongnu.org; Tue, 26 May 2015 08:56:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxEOt-0005mo-Jx for qemu-devel@nongnu.org; Tue, 26 May 2015 08:56:07 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4QCu61m023627 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 26 May 2015 08:56:07 -0400 Date: Tue, 26 May 2015 20:56:04 +0800 From: Fam Zheng Message-ID: <20150526125604.GC13749@ad.nay.redhat.com> References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com> <1430152117-100558-30-git-send-email-pbonzini@redhat.com> <20150526124936.GB13749@ad.nay.redhat.com> <55646C76.7070807@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55646C76.7070807@redhat.com> Subject: Re: [Qemu-devel] [PATCH 29/29] memory: strengthen assertions on mr->terminates List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On Tue, 05/26 14:52, Paolo Bonzini wrote: > > > On 26/05/2015 14:49, Fam Zheng wrote: > > It would be nicer to introduce a memory_region_is_ram(MemoryRegion *mr), the > > ~(ram_addr_t) duplications are too many. > > Is RAM_ADDR_INVALID okay too? I think so. If you replace every ~(ram_addr_t)0 with RAM_ADDR_INVALID, you can add my Reviewed-by: Fam Zheng