From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50167)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YxZEH-0005JL-0d
	for qemu-devel@nongnu.org; Wed, 27 May 2015 07:10:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YxZEB-0008PH-Jm
	for qemu-devel@nongnu.org; Wed, 27 May 2015 07:10:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37691)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YxZEB-0008P3-B0
	for qemu-devel@nongnu.org; Wed, 27 May 2015 07:10:27 -0400
Date: Wed, 27 May 2015 12:10:15 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150527121009-mutt-send-email-mst@redhat.com>
References: <1432522520-8068-1-git-send-email-zhaoshenglong@huawei.com>
	<1432522520-8068-19-git-send-email-zhaoshenglong@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1432522520-8068-19-git-send-email-zhaoshenglong@huawei.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v9 18/24] hw/acpi/aml-build: Add aml_else()
	term
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, alex.bennee@linaro.org, hanjun.guo@linaro.org, imammedo@redhat.com, pbonzini@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org, shannon.zhao@linaro.org

On Mon, May 25, 2015 at 10:55:14AM +0800, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>=20
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> Reviewed-by: Alex Benn=E9e <alex.bennee@linaro.org>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/acpi/aml-build.c         | 7 +++++++
>  include/hw/acpi/aml-build.h | 1 +
>  2 files changed, 8 insertions(+)
>=20
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 56cce41..cfe1b29 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -632,6 +632,13 @@ Aml *aml_if(Aml *predicate)
>      return var;
>  }
> =20
> +/* ACPI 1.0b: 16.2.5.3 Type 1 Opcodes Encoding: DefElse */
> +Aml *aml_else(void)
> +{
> +    Aml *var =3D aml_bundle(0xA1 /* ElseOp */, AML_PACKAGE);
> +    return var;
> +}
> +
>  /* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefMethod */
>  Aml *aml_method(const char *name, int arg_count)
>  {
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index 41b2cdd..c999ef1 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -254,6 +254,7 @@ Aml *aml_scope(const char *name_format, ...) GCC_FM=
T_ATTR(1, 2);
>  Aml *aml_device(const char *name_format, ...) GCC_FMT_ATTR(1, 2);
>  Aml *aml_method(const char *name, int arg_count);
>  Aml *aml_if(Aml *predicate);
> +Aml *aml_else(void);
>  Aml *aml_package(uint8_t num_elements);
>  Aml *aml_buffer(int buffer_size, uint8_t *byte_list);
>  Aml *aml_resource_template(void);
> --=20
> 2.0.4
>=20