From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxbt7-0003E0-Ki for qemu-devel@nongnu.org; Wed, 27 May 2015 10:00:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxbt1-0007pb-SR for qemu-devel@nongnu.org; Wed, 27 May 2015 10:00:53 -0400 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:33989) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxbt1-0007pN-LA for qemu-devel@nongnu.org; Wed, 27 May 2015 10:00:47 -0400 Received: by wgv5 with SMTP id 5so10458019wgv.1 for ; Wed, 27 May 2015 07:00:46 -0700 (PDT) Date: Wed, 27 May 2015 15:00:43 +0100 From: Stefan Hajnoczi Message-ID: <20150527140043.GA1454@stefanha-thinkpad.redhat.com> References: <55645794.3020202@redhat.com> <1432644847-7566-1-git-send-email-michael.i.doherty@intel.com> <1432644847-7566-2-git-send-email-michael.i.doherty@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline In-Reply-To: <1432644847-7566-2-git-send-email-michael.i.doherty@intel.com> Subject: Re: [Qemu-devel] [PATCH v3 2/2] qemu-bridge-helper: Use stateless configuration for bridge.conf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ikey Doherty Cc: qemu-devel@nongnu.org --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 26, 2015 at 01:54:07PM +0100, Ikey Doherty wrote: > The goal of stateless, and thus this change, is to separate OS configurat= ion > from system administrator configuration. With this change we will read the > default configuration data from /usr/share/defaults/qemu, in the absence = of > an overriding site administrator configuration in /etc/qemu. >=20 > A key advantage of this change is enabling a sane and immutable default OS > configuration, that is resiliant to upgrades. Ultimate power is still left > to the system administrator, with the ability to override the defaults if > required. Lastly, given that the sane defaults are always available, the > administrator may simply remove their site-config files to reset the > configuration to the "factory defaults" (i.e. OS configuration). >=20 > Signed-off-by: Ikey Doherty > --- > configure | 2 ++ > qemu-bridge-helper.c | 15 +++++++++------ > 2 files changed, 11 insertions(+), 6 deletions(-) >=20 > diff --git a/configure b/configure > index f758f32..a0b6477 100755 > --- a/configure > +++ b/configure > @@ -4303,6 +4303,7 @@ fi > qemu_confdir=3D$sysconfdir$confsuffix > qemu_moddir=3D$libdir$confsuffix > qemu_datadir=3D$datadir$confsuffix > +qemu_defaultdir=3D"$datadir/defaults$confsuffix" > qemu_localedir=3D"$datadir/locale" > =20 > tools=3D"" > @@ -4543,6 +4544,7 @@ echo "mandir=3D$mandir" >> $config_host_mak > echo "sysconfdir=3D$sysconfdir" >> $config_host_mak > echo "qemu_confdir=3D$qemu_confdir" >> $config_host_mak > echo "qemu_datadir=3D$qemu_datadir" >> $config_host_mak > +echo "qemu_defaultdir=3D$qemu_defaultdir" >> $config_host_mak > echo "qemu_docdir=3D$qemu_docdir" >> $config_host_mak > echo "qemu_moddir=3D$qemu_moddir" >> $config_host_mak > if test "$mingw32" =3D "no" ; then Changes to ./configure would make a nice separate commit where you can explain the file layout for stateless configuration. That way it's also easier to cherry-pick or revert the ./configure change without bringing in the qemu-bridge-helper.c change. --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVZc4LAAoJEJykq7OBq3PIlVAH/jXODUEMDbvtB2deFG1EGMf/ +5ksdg0WNFaaM6etnWWJG9CAdGoawzLd5QzgDyb2ZpbkDLV+wr5H69U7bvj75Vtd KnsYEbaTh/T9eSQqVHANm8QjwbCBWzojhQH4zt1+pFJNpc4D6vDrSqPzwwmelZva 5jPQde6A9flQ0G4Ftd0hbo2/hnvBfTwTyREaNtzrIeJj6cQbrnWnUYmxUGZffLVA uJlbAsvntmgOKi7Kyuj0jDeMzhE3j1yMNaC8Bv4ZsXnRDcBzNrjLc1DkwhV1i+Ws ZOuK5BXW8Kp3ANu16VuTdXNnlYRbhE+aIP0ijlB+RtF1Pjs9aXv/0CR1PC8ILPA= =nRIY -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs--