From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43557)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YxoOb-0005pt-Rv
	for qemu-devel@nongnu.org; Wed, 27 May 2015 23:22:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YxoOY-000283-Lj
	for qemu-devel@nongnu.org; Wed, 27 May 2015 23:22:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38784)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YxoOY-00027w-8Q
	for qemu-devel@nongnu.org; Wed, 27 May 2015 23:22:10 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id DDCCF19F200
	for <qemu-devel@nongnu.org>; Thu, 28 May 2015 03:22:09 +0000 (UTC)
Date: Thu, 28 May 2015 11:22:07 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150528032207.GA6975@dhcp-14-238.nay.redhat.com>
References: <1432325832-12887-1-git-send-email-jsnow@redhat.com>
	<1432325832-12887-5-git-send-email-jsnow@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1432325832-12887-5-git-send-email-jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] iotests: clarify help text
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org

On Fri, 05/22 16:17, John Snow wrote:
> Split the help text to highlight the groups of options
> a little better, carving out a clear "format" and
> "protocols" section.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>

Reviewed-by: Fam Zheng <famz@redhat.com>

> ---
>  tests/qemu-iotests/common | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common
> index b3d869e..9456aa0 100644
> --- a/tests/qemu-iotests/common
> +++ b/tests/qemu-iotests/common
> @@ -134,7 +134,7 @@ s/ .*//p
>  common options
>      -v                  verbose
>  
> -check options
> +image format options
>      -raw                test raw (default)
>      -bochs              test bochs
>      -cloop              test cloop
> @@ -146,6 +146,8 @@ check options
>      -vpc                test vpc
>      -vhdx               test vhdx
>      -vmdk               test vmdk
> +
> +image protocol options
>      -file               test file (default)
>      -rbd                test rbd
>      -sheepdog           test sheepdog
> @@ -153,6 +155,8 @@ check options
>      -ssh                test ssh
>      -nfs                test nfs
>      -archipelago        test archipelago
> +
> +other options
>      -xdiff              graphical mode diff
>      -nocache            use O_DIRECT on backing file
>      -misalign           misalign memory allocations
> -- 
> 2.1.0
>