From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: peter.crosthwaite@xilinx.com, qemu-devel@nongnu.org,
afaerber@suse.de, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v2 1/5] target-microblaze: Fix up indentation
Date: Thu, 28 May 2015 16:33:09 +1000 [thread overview]
Message-ID: <20150528063309.GS30952@toto> (raw)
In-Reply-To: <80d478629df9a635771d46f2b4f85cb94c186b26.1432790821.git.alistair.francis@xilinx.com>
On Thu, May 28, 2015 at 03:36:25PM +1000, Alistair Francis wrote:
> Fix up the incorrect indentation level in the helper_stackprot() function.
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> ---
>
> target-microblaze/op_helper.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/target-microblaze/op_helper.c b/target-microblaze/op_helper.c
> index a4c8f04..d2b3624 100644
> --- a/target-microblaze/op_helper.c
> +++ b/target-microblaze/op_helper.c
> @@ -468,11 +468,11 @@ void helper_memalign(CPUMBState *env, uint32_t addr, uint32_t dr, uint32_t wr,
> void helper_stackprot(CPUMBState *env, uint32_t addr)
> {
> if (addr < env->slr || addr > env->shr) {
> - qemu_log("Stack protector violation at %x %x %x\n",
> - addr, env->slr, env->shr);
> - env->sregs[SR_EAR] = addr;
> - env->sregs[SR_ESR] = ESR_EC_STACKPROT;
> - helper_raise_exception(env, EXCP_HW_EXCP);
> + qemu_log("Stack protector violation at %x %x %x\n",
> + addr, env->slr, env->shr);
> + env->sregs[SR_EAR] = addr;
> + env->sregs[SR_ESR] = ESR_EC_STACKPROT;
> + helper_raise_exception(env, EXCP_HW_EXCP);
> }
> }
>
> --
> 1.7.1
>
next prev parent reply other threads:[~2015-05-28 6:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 5:35 [Qemu-devel] [PATCH v2 0/5] Add Microblaze configuration options Alistair Francis
2015-05-28 5:36 ` [Qemu-devel] [PATCH v2 1/5] target-microblaze: Fix up indentation Alistair Francis
2015-05-28 6:33 ` Edgar E. Iglesias [this message]
2015-05-28 5:37 ` [Qemu-devel] [PATCH v2 2/5] target-microblaze: Preserve the pvr registers during reset Alistair Francis
2015-05-28 6:42 ` Edgar E. Iglesias
2015-05-28 5:37 ` [Qemu-devel] [PATCH v2 3/5] target-microblaze: Allow the stack protection to be disabled/enabled Alistair Francis
2015-05-28 6:17 ` Edgar E. Iglesias
2015-05-29 5:35 ` Alistair Francis
2015-05-29 5:39 ` Alistair Francis
2015-05-29 5:42 ` Edgar E. Iglesias
2015-05-29 5:51 ` Alistair Francis
2015-05-28 5:38 ` [Qemu-devel] [PATCH v2 4/5] target-microblaze: Tidy up the base-vectors property Alistair Francis
2015-05-28 5:38 ` [Qemu-devel] [PATCH v2 5/5] target-microblaze: Convert use-fpu to a CPU property Alistair Francis
2015-05-28 6:25 ` Edgar E. Iglesias
2015-05-29 5:50 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528063309.GS30952@toto \
--to=edgar.iglesias@xilinx.com \
--cc=afaerber@suse.de \
--cc=alistair.francis@xilinx.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).