From: "Daniel P. Berrange" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>,
gtk-vnc-list@gnome.org, 772422@bugs.debian.org,
qemu-devel@nongnu.org,
Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>
Subject: Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map
Date: Thu, 28 May 2015 09:52:24 +0100 [thread overview]
Message-ID: <20150528085224.GA18786@redhat.com> (raw)
In-Reply-To: <1432794244.12688.10.camel@nilsson.home.kraxel.org>
On Thu, May 28, 2015 at 08:24:04AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > For EVDEV_KPCOMMA it maps to XT KBD code 126 (0x7e in decimal) which
> > does not match your patch. I'm not sure where I got that mapping
> > from originally - probably from the Linux kernel's XT <-> evdev
> > keymapping tables.
>
> Did some more testing, 0x7e seems to be the correct one. Everything is
> consistent with that one: vnc client, input_event_key_* trace event,
> input-events reporting within the guest. So no change needed in
> gtk-vnc, I'll update the qemu patch.
Ah excellant, thanks for letting me know.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
prev parent reply other threads:[~2015-05-28 8:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 13:58 [Qemu-devel] [PATCH 1/2] kbd: add brazil kbd keys to qemu Gerd Hoffmann
2015-05-26 13:58 ` [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map Gerd Hoffmann
2015-05-27 9:27 ` Joao Luis Meloni Assirati
2015-05-27 14:32 ` Gerd Hoffmann
2015-05-27 19:04 ` Joao Luis Meloni Assirati
2015-05-27 11:19 ` Markus Armbruster
2015-05-27 11:35 ` Daniel P. Berrange
2015-05-27 14:39 ` Gerd Hoffmann
2015-05-27 11:40 ` Daniel P. Berrange
2015-05-27 14:42 ` Gerd Hoffmann
2015-05-28 6:24 ` Gerd Hoffmann
2015-05-28 8:52 ` Daniel P. Berrange [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528085224.GA18786@redhat.com \
--to=berrange@redhat.com \
--cc=772422@bugs.debian.org \
--cc=gtk-vnc-list@gnome.org \
--cc=jlma@nonada.if.usp.br \
--cc=kraxel@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).