From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35302)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1YxtYF-0006Ib-TD
	for qemu-devel@nongnu.org; Thu, 28 May 2015 04:52:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1YxtYD-0005u9-7f
	for qemu-devel@nongnu.org; Thu, 28 May 2015 04:52:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33562)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1YxtYD-0005u1-39
	for qemu-devel@nongnu.org; Thu, 28 May 2015 04:52:29 -0400
Date: Thu, 28 May 2015 09:52:24 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20150528085224.GA18786@redhat.com>
References: <1432648685-17925-1-git-send-email-kraxel@redhat.com>
	<1432648685-17925-2-git-send-email-kraxel@redhat.com>
	<20150527114025.GC6364@redhat.com>
	<1432794244.12688.10.camel@nilsson.home.kraxel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1432794244.12688.10.camel@nilsson.home.kraxel.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev
 map
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>, gtk-vnc-list@gnome.org, 772422@bugs.debian.org, qemu-devel@nongnu.org, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>

On Thu, May 28, 2015 at 08:24:04AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > For EVDEV_KPCOMMA it maps to XT KBD code 126 (0x7e in decimal) which
> > does not match your patch.  I'm not sure where I got that mapping
> > from originally - probably from the Linux kernel's XT <-> evdev
> > keymapping tables.
> 
> Did some more testing, 0x7e seems to be the correct one.  Everything is
> consistent with that one:  vnc client, input_event_key_* trace event,
> input-events reporting within the guest.  So no change needed in
> gtk-vnc, I'll update the qemu patch.

Ah excellant, thanks for letting me know.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|