From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35676)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1YxtZR-0007K2-L5
	for qemu-devel@nongnu.org; Thu, 28 May 2015 04:53:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1YxtZO-000692-UQ
	for qemu-devel@nongnu.org; Thu, 28 May 2015 04:53:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42805)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1YxtZO-00068x-Pd
	for qemu-devel@nongnu.org; Thu, 28 May 2015 04:53:42 -0400
Date: Thu, 28 May 2015 09:53:37 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20150528085337.GB18786@redhat.com>
References: <1432798845-10118-1-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1432798845-10118-1-git-send-email-kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] kbd: add brazil kbd keys to qemu
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, Michael Tokarev <mjt@tls.msk.ru>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, 772422@bugs.debian.org, gtk-vnc-list@gnome.org

On Thu, May 28, 2015 at 09:40:44AM +0200, Gerd Hoffmann wrote:
> The brazilian computer keyboard layout has two extra keys (compared to
> the usual 105-key intl ps/2 keyboard).  This patch makes these two keys
> known to qemu.
> 
> For historic reasons qemu has two ways to specify a key:  A QKeyCode
> (name-based) or a number (ps/2 scancode based).  Therefore we have to
> update multiple places to make new keys known to qemu:
> 
>   (1) The QKeyCode definition in qapi-schema.json
>   (2) The QKeyCode <-> number mapping table in ui/input-keymap.c
> 
> This patch does just that.  With this patch applied you can send those
> two keys to the guest using the send-key monitor command.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|