From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51621)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YxwJG-00020k-Gd
	for qemu-devel@nongnu.org; Thu, 28 May 2015 07:49:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YxwJF-00049E-Nk
	for qemu-devel@nongnu.org; Thu, 28 May 2015 07:49:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35357)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YxwJF-000492-7a
	for qemu-devel@nongnu.org; Thu, 28 May 2015 07:49:13 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id 5A0DABF9EF
	for <qemu-devel@nongnu.org>; Thu, 28 May 2015 11:49:12 +0000 (UTC)
Date: Thu, 28 May 2015 13:49:09 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150528124726-mutt-send-email-mst@redhat.com>
References: <1430133591-6197-1-git-send-email-ghammer@redhat.com>
	<1430133591-6197-5-git-send-email-ghammer@redhat.com>
	<5566ED24.3060205@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5566ED24.3060205@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine
	Generation ID device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gal Hammer <ghammer@redhat.com>, imammedo@redhat.com, qemu-devel@nongnu.org

On Thu, May 28, 2015 at 12:25:40PM +0200, Paolo Bonzini wrote:
> 
> 
> On 27/04/2015 13:19, Gal Hammer wrote:
> > +static void vmgenid_init(Object *obj)
> > +{
> > +    SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
> > +    VmGenIdState *s = VMGENID(obj);
> > +
> > +    memory_region_init_io(&s->iomem, obj, &vmgenid_ram_ops, s, "vgid", 16);
> 
> This is a small problem.  The spec says the memory of the VMGENID should
> not be uncacheable, but MMIO _should_ be uncacheable.
> 
> This is running on a VM so we maybe not care, but it's worth pointing it
> out.
> 
> Paolo

Exactly.

> > +    sysbus_init_mmio(sbd, &s->iomem);
> > +
> > +    object_property_add_str(obj, PROPERTY_UUID, NULL, vmgenid_set_uuid, NULL);
> > +}
> > +