Re: [Qemu-devel] [RFC v6 0/2] monitor: add memory search commands s, sp

[Luiz Capitulino <lcapitulino@redhat.com>]

On Mon, 18 May 2015 13:22:16 +0200
hw.claudio@gmail.com wrote:

> From: Claudio Fontana <claudio.fontana@huawei.com>
> 
> This is the latest iteration of the memory search patch,
> including a trivial replacement for the memmem function for systems
> which don't provide one (notably Windows).
> 
> It detects the presence of memmem in configure and sets CONFIG_MEMMEM,
> providing a trivial implementation for the !CONFIG_MEMMEM case.
> 
> The new code is MIT licensed, following usage of other files in the same
> directory dealing with replacement functions (osdep, oslib, getauxval etc),
> and to maximize reusability.
> 
> I have tested this in both CONFIG_MEMMEM defined/undefined scenarios,
> but more feedback and testing is welcome of course.
> 
> changes from v5:
> dropped the import from gnulib and implemented a trivial replacement.
> 
> changes from v4:
> made into a series of two patches.
> Introduced a memmem replacement function (import from gnulib)
> and detection code in configure.
> 
> changes from v3:
> initialize pointer variable to NULL to finally get rid of spurious warning
> 
> changes from v2:
> move code to try to address spurious warning
> 
> changes from v1:
> make checkpatch happy by adding braces here and there.
> 
> 
> Claudio Fontana (2):
>   util: add memmem replacement function
>   monitor: add memory search commands s, sp

Applied to the qmp branch, thanks.

> 
>  configure            |  15 ++++++
>  hmp-commands.hx      |  28 +++++++++++
>  include/qemu/osdep.h |   4 ++
>  monitor.c            | 140 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  util/Makefile.objs   |   1 +
>  util/memmem.c        |  62 +++++++++++++++++++++++
>  6 files changed, 250 insertions(+)
>  create mode 100644 util/memmem.c
>