From: Kevin Wolf <kwolf@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
"open list:Floppy" <qemu-block@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
John Snow <jsnow@redhat.com>, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] floppy: fix I/O ranges in both portio and acpi dsdt
Date: Thu, 28 May 2015 18:36:40 +0200 [thread overview]
Message-ID: <20150528163640.GE3385@noname.redhat.com> (raw)
In-Reply-To: <1432827461-1117-1-git-send-email-kraxel@redhat.com>
Am 28.05.2015 um 17:37 hat Gerd Hoffmann geschrieben:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/block/fdc.c | 2 +-
> hw/i386/acpi-dsdt-isa.dsl | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
The commit message could be a bit longer, I don't think this change is
obvious.
My FDC spec says that this version of the controller doesn't have the
SRA register any more, and the emulation was added in the context of a
Sun4m patch (commit 8c6a4d774). Therefore my default assumption would be
that it's intentionally not accessible and not needed on isa-fdc.
I'm happy to get that assumption corrected, but it needs a non-empty
commit message for that.
Kevin
> diff --git a/hw/block/fdc.c b/hw/block/fdc.c
> index d8a8edd..c761291 100644
> --- a/hw/block/fdc.c
> +++ b/hw/block/fdc.c
> @@ -2186,7 +2186,7 @@ static void fdctrl_realize_common(FDCtrl *fdctrl, Error **errp)
> }
>
> static const MemoryRegionPortio fdc_portio_list[] = {
> - { 1, 5, 1, .read = fdctrl_read, .write = fdctrl_write },
> + { 0, 6, 1, .read = fdctrl_read, .write = fdctrl_write },
> { 7, 1, 1, .read = fdctrl_read, .write = fdctrl_write },
> PORTIO_END_OF_LIST(),
> };
> diff --git a/hw/i386/acpi-dsdt-isa.dsl b/hw/i386/acpi-dsdt-isa.dsl
> index 89caa16..f71d7df 100644
> --- a/hw/i386/acpi-dsdt-isa.dsl
> +++ b/hw/i386/acpi-dsdt-isa.dsl
> @@ -58,7 +58,7 @@ Scope(\_SB.PCI0.ISA) {
> }
> }
> Name(_CRS, ResourceTemplate() {
> - IO(Decode16, 0x03F2, 0x03F2, 0x00, 0x04)
> + IO(Decode16, 0x03F0, 0x03F0, 0x00, 0x06)
> IO(Decode16, 0x03F7, 0x03F7, 0x00, 0x01)
> IRQNoFlags() { 6 }
> DMA(Compatibility, NotBusMaster, Transfer8) { 2 }
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2015-05-28 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 15:37 [Qemu-devel] [PATCH] floppy: fix I/O ranges in both portio and acpi dsdt Gerd Hoffmann
2015-05-28 16:36 ` Kevin Wolf [this message]
2015-05-29 6:19 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528163640.GE3385@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).