From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37592)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Yy0nh-0007fW-9n
	for qemu-devel@nongnu.org; Thu, 28 May 2015 12:37:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Yy0nc-0004IY-51
	for qemu-devel@nongnu.org; Thu, 28 May 2015 12:36:57 -0400
Date: Thu, 28 May 2015 18:36:40 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20150528163640.GE3385@noname.redhat.com>
References: <1432827461-1117-1-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1432827461-1117-1-git-send-email-kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] floppy: fix I/O ranges in both portio and
	acpi dsdt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>, "open list:Floppy" <qemu-block@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>, Richard Henderson <rth@twiddle.net>

Am 28.05.2015 um 17:37 hat Gerd Hoffmann geschrieben:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/block/fdc.c            | 2 +-
>  hw/i386/acpi-dsdt-isa.dsl | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

The commit message could be a bit longer, I don't think this change is
obvious.

My FDC spec says that this version of the controller doesn't have the
SRA register any more, and the emulation was added in the context of a
Sun4m patch (commit 8c6a4d774). Therefore my default assumption would be
that it's intentionally not accessible and not needed on isa-fdc.

I'm happy to get that assumption corrected, but it needs a non-empty
commit message for that.

Kevin


> diff --git a/hw/block/fdc.c b/hw/block/fdc.c
> index d8a8edd..c761291 100644
> --- a/hw/block/fdc.c
> +++ b/hw/block/fdc.c
> @@ -2186,7 +2186,7 @@ static void fdctrl_realize_common(FDCtrl *fdctrl, Error **errp)
>  }
>  
>  static const MemoryRegionPortio fdc_portio_list[] = {
> -    { 1, 5, 1, .read = fdctrl_read, .write = fdctrl_write },
> +    { 0, 6, 1, .read = fdctrl_read, .write = fdctrl_write },
>      { 7, 1, 1, .read = fdctrl_read, .write = fdctrl_write },
>      PORTIO_END_OF_LIST(),
>  };
> diff --git a/hw/i386/acpi-dsdt-isa.dsl b/hw/i386/acpi-dsdt-isa.dsl
> index 89caa16..f71d7df 100644
> --- a/hw/i386/acpi-dsdt-isa.dsl
> +++ b/hw/i386/acpi-dsdt-isa.dsl
> @@ -58,7 +58,7 @@ Scope(\_SB.PCI0.ISA) {
>              }
>          }
>          Name(_CRS, ResourceTemplate() {
> -            IO(Decode16, 0x03F2, 0x03F2, 0x00, 0x04)
> +            IO(Decode16, 0x03F0, 0x03F0, 0x00, 0x06)
>              IO(Decode16, 0x03F7, 0x03F7, 0x00, 0x01)
>              IRQNoFlags() { 6 }
>              DMA(Compatibility, NotBusMaster, Transfer8) { 2 }
> -- 
> 1.8.3.1
>