From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40381)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yy4jH-00011l-0o
	for qemu-devel@nongnu.org; Thu, 28 May 2015 16:48:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yy4jA-0002fL-Re
	for qemu-devel@nongnu.org; Thu, 28 May 2015 16:48:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38881)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yy4jA-0002cS-MB
	for qemu-devel@nongnu.org; Thu, 28 May 2015 16:48:32 -0400
Date: Thu, 28 May 2015 22:48:26 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150528204826.GA14468@redhat.com>
References: <1432650887-54604-1-git-send-email-cornelia.huck@de.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1432650887-54604-1-git-send-email-cornelia.huck@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH RFC v2 0/1] virtio: host features in vdev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: qemu-devel@nongnu.org, shannon.zhao@linaro.org

On Tue, May 26, 2015 at 04:34:46PM +0200, Cornelia Huck wrote:
> Next version of the patch moving the host features from the transports
> into the vdev. I have not yet tested migration (probably ok, though),
> but the rest should be fine.
> 
> I'll try to see how the feature bit changes for virtio-1 work out on
> top of this.
> 
> v1->v2: remove host features from virtio-pci and s390-virtio transport
>         proxies [Shannon Zhao]
> 
> Cornelia Huck (1):
>   virtio: move host_features
> 
>  hw/s390x/s390-virtio-bus.c     | 18 ++----------------
>  hw/s390x/s390-virtio-bus.h     |  1 -
>  hw/s390x/virtio-ccw.c          | 29 ++++++-----------------------
>  hw/s390x/virtio-ccw.h          |  4 ----
>  hw/virtio/virtio-bus.c         | 18 +++++-------------
>  hw/virtio/virtio-mmio.c        | 22 +++-------------------
>  hw/virtio/virtio-pci.c         | 17 ++++-------------
>  hw/virtio/virtio-pci.h         |  1 -
>  hw/virtio/virtio.c             | 17 +++++++++--------
>  include/hw/virtio/virtio-bus.h |  1 -
>  include/hw/virtio/virtio.h     |  1 +
>  11 files changed, 30 insertions(+), 99 deletions(-)

I like the diffstat!
Don't see anything wrong here, though a couple more cleanups
are possible on top.

> -- 
> 2.3.7