From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyCdx-0006zk-Gk for qemu-devel@nongnu.org; Fri, 29 May 2015 01:15:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyCdw-0001fs-Mn for qemu-devel@nongnu.org; Fri, 29 May 2015 01:15:41 -0400 Date: Fri, 29 May 2015 08:15:34 +0300 From: Dimitris Aragiorgis Message-ID: <20150529051534.GA20809@arr> References: <1432115859-11413-1-git-send-email-dimara@arrikto.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Content-Disposition: inline In-Reply-To: <1432115859-11413-1-git-send-email-dimara@arrikto.com> Subject: Re: [Qemu-devel] [PATCH v4 0/5] Some fixes related to scsi-generic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-block@nongnu.org, stefanha@redhat.com --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, * Dimitris Aragiorgis [2015-05-20 12:57:34 +0300]: > Hi all, >=20 > These four patches make slight changes to the way QEMU handles SCSI > generic devices to fix a number of small problems. >=20 > I am sending them against the master branch, since I don't know if they > can be considered bugfixes. >=20 > Thanks, > dimara >=20 > v4 (rebased to current master): > * Avoid errno clobbering with DPRINTF + strerror() (Eric's comment) > * Use {} in #define macro even if it is not necessary (single commands) >=20 Any news on this? Thanks, dimara > v3 (rebased to current master): > * Avoid bit-rot in DPRINTF (adopt Eric's suggestion) > * Address Kevin's comments (DEBUF_FLOPPY, line > 80 chars, SG device) > * Mention Kevin's comment wrt disk flush in the corresponding commit >=20 > v2: > * remove duplicate check for sg inside iscsi_co_flush() > * remove DEBUG_BLOCK_PRINT in block/raw-posix.c > * use DPRINTF for debugging in block/raw-posix.c >=20 > PS: Paolo suggested to use a tracepoint inside hdev_is_sg() but I chose D= PRINTF > instead. It would make sense to add a tracepoint for bdrv_is_sg() (just l= ike > most bdrv_* commands) but this is too much for now since it just returns = the > bs->sg flag (and is not an actual driver function). If you insist I'll ch= ange > it in v3. >=20 > Dimitris Aragiorgis (5): > block: Use bdrv_is_sg() everywhere > Fix migration in case of scsi-generic > raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT > raw-posix: Use DPRINTF for DEBUG_FLOPPY > raw-posix: Introduce hdev_is_sg() >=20 > block.c | 6 ++-- > block/io.c | 3 +- > block/iscsi.c | 4 --- > block/raw-posix.c | 91 +++++++++++++++++++++++++++++++----------------= ------ > 4 files changed, 58 insertions(+), 46 deletions(-) >=20 > --=20 > 1.7.10.4 >=20 --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAEBAgAGBQJVZ/X2AAoJEHFDHex6CBG9ihEH/3RzP1aCLEJwjU1cmWheKMNT rb7HupEZ0/6wQcp45ML7gVEBi9+bTRM3aQtm+65m5TsSe8c4Ja7F7kYQXzb3ke3M m61TRzomvxDwaC24OdIcVm7kn7ZzkyVrFshnOVYrWgfJYANv3xwu1++7SlHRr+wV qMUvkDPzr3WI2OlzdYr68r0c1Ju+DNgXdFJHhnEj8BLocCZhkHXiMSMAg9DhkZD/ 4Lrc20r3TIhBRP+fIJN1vpsTPnIQTf2vjoqeoPgke2IhA+YnKU4ajVntJD/JVKZL tH+N1qkgxUfIUv7m4QJt2HI/RJUnUqw7HntbXZQckkY6KYaUlFm1qFmz+HwKf/M= =+NJQ -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--