qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: peter.crosthwaite@xilinx.com, qemu-devel@nongnu.org,
	afaerber@suse.de, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v3 6/6] target-microblaze: Disable stack protection by default
Date: Fri, 29 May 2015 16:52:28 +1000	[thread overview]
Message-ID: <20150529065228.GD30952@toto> (raw)
In-Reply-To: <9bda5ca4b4fc810cff97a4718ee9928d76864761.1432879373.git.alistair.francis@xilinx.com>

On Fri, May 29, 2015 at 04:32:35PM +1000, Alistair Francis wrote:
> Stack protection is not available when the MMU is enabled.
> As the MMU is enabled by default, disable stack protection
> by default.
> 
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>


Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>


> ---
> 
>  target-microblaze/cpu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c
> index b857056..13ae49a 100644
> --- a/target-microblaze/cpu.c
> +++ b/target-microblaze/cpu.c
> @@ -162,7 +162,7 @@ static const VMStateDescription vmstate_mb_cpu = {
>  static Property mb_properties[] = {
>      DEFINE_PROP_UINT32("base-vectors", MicroBlazeCPU, cfg.base_vectors, 0),
>      DEFINE_PROP_BOOL("use-stack-protection", MicroBlazeCPU, cfg.stackprot,
> -                     true),
> +                     false),
>      /* If use-fpu > 0 - FPU is enabled
>       * If use-fpu = 2 - Floating point conversion and square root instructions
>       *                  are enabled
> -- 
> 1.7.1
> 

  reply	other threads:[~2015-05-29  6:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29  6:28 [Qemu-devel] [PATCH v3 0/6] Add Microblaze configuration options Alistair Francis
2015-05-29  6:29 ` [Qemu-devel] [PATCH v3 1/6] target-microblaze: Fix up indentation Alistair Francis
2015-05-29  6:30 ` [Qemu-devel] [PATCH v3 2/6] target-microblaze: Preserve the pvr registers during reset Alistair Francis
2015-05-29  6:30 ` [Qemu-devel] [PATCH v3 3/6] target-microblaze: Allow the stack protection to be disabled Alistair Francis
2015-05-29  6:46   ` Edgar E. Iglesias
2015-05-29  6:31 ` [Qemu-devel] [PATCH v3 4/6] target-microblaze: Tidy up the base-vectors property Alistair Francis
2015-05-29  6:31 ` [Qemu-devel] [PATCH v3 5/6] target-microblaze: Convert use-fpu to a CPU property Alistair Francis
2015-05-29  6:51   ` Edgar E. Iglesias
2015-05-29  6:32 ` [Qemu-devel] [PATCH v3 6/6] target-microblaze: Disable stack protection by default Alistair Francis
2015-05-29  6:52   ` Edgar E. Iglesias [this message]
2015-05-29  6:58 ` [Qemu-devel] [PATCH v3 0/6] Add Microblaze configuration options Edgar E. Iglesias
2015-05-29  7:08   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150529065228.GD30952@toto \
    --to=edgar.iglesias@xilinx.com \
    --cc=afaerber@suse.de \
    --cc=alistair.francis@xilinx.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).