From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59688)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1YyEDd-0005QP-An
	for qemu-devel@nongnu.org; Fri, 29 May 2015 02:56:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1YyEDa-0001E9-2K
	for qemu-devel@nongnu.org; Fri, 29 May 2015 02:56:37 -0400
Received: from mail-by2on0094.outbound.protection.outlook.com
	([207.46.100.94]:58061
	helo=na01-by2-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1YyEDZ-0001Dv-N6
	for qemu-devel@nongnu.org; Fri, 29 May 2015 02:56:33 -0400
Date: Fri, 29 May 2015 16:52:28 +1000
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Message-ID: <20150529065228.GD30952@toto>
References: <cover.1432879373.git.alistair.francis@xilinx.com>
	<9bda5ca4b4fc810cff97a4718ee9928d76864761.1432879373.git.alistair.francis@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <9bda5ca4b4fc810cff97a4718ee9928d76864761.1432879373.git.alistair.francis@xilinx.com>
Subject: Re: [Qemu-devel] [PATCH v3 6/6] target-microblaze: Disable stack
 protection by default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: peter.crosthwaite@xilinx.com, qemu-devel@nongnu.org, afaerber@suse.de, rth@twiddle.net

On Fri, May 29, 2015 at 04:32:35PM +1000, Alistair Francis wrote:
> Stack protection is not available when the MMU is enabled.
> As the MMU is enabled by default, disable stack protection
> by default.
> 
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>


Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>


> ---
> 
>  target-microblaze/cpu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c
> index b857056..13ae49a 100644
> --- a/target-microblaze/cpu.c
> +++ b/target-microblaze/cpu.c
> @@ -162,7 +162,7 @@ static const VMStateDescription vmstate_mb_cpu = {
>  static Property mb_properties[] = {
>      DEFINE_PROP_UINT32("base-vectors", MicroBlazeCPU, cfg.base_vectors, 0),
>      DEFINE_PROP_BOOL("use-stack-protection", MicroBlazeCPU, cfg.stackprot,
> -                     true),
> +                     false),
>      /* If use-fpu > 0 - FPU is enabled
>       * If use-fpu = 2 - Floating point conversion and square root instructions
>       *                  are enabled
> -- 
> 1.7.1
>