From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40757)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1YyLFh-0004N3-8p
	for qemu-devel@nongnu.org; Fri, 29 May 2015 10:27:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1YyLFg-0001Jp-IS
	for qemu-devel@nongnu.org; Fri, 29 May 2015 10:27:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59346)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1YyLFg-0001Jl-DC
	for qemu-devel@nongnu.org; Fri, 29 May 2015 10:27:12 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (Postfix) with ESMTPS id 0A7D82D44E2
	for <qemu-devel@nongnu.org>; Fri, 29 May 2015 14:27:12 +0000 (UTC)
Date: Fri, 29 May 2015 10:27:11 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20150529102711.50be82f6@redhat.com>
In-Reply-To: <87y4k7v4w4.fsf@blackfin.pond.sub.org>
References: <1432893420-18687-1-git-send-email-armbru@redhat.com>
	<1432893420-18687-15-git-send-email-armbru@redhat.com>
	<87y4k7v4w4.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 14/21] monitor: Limit QError use to
	command handlers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, 29 May 2015 16:23:55 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> The following hunk needs to be squashed in:
> 
> diff --git a/monitor.c b/monitor.c
> index 16bd567..888d771 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -5005,7 +5005,6 @@ static void handle_qmp_command(JSONMessageParser *parser, QList *tokens)
>          goto err_out;
>      }
>      if (invalid_qmp_mode(mon, cmd, &local_err)) {
> -        qerror_report_err(local_err);
>          goto err_out;
>      }

Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>

>  
>