From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyJ7n-0001EB-Bs for qemu-devel@nongnu.org; Fri, 29 May 2015 08:10:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyJ7j-0000JO-B5 for qemu-devel@nongnu.org; Fri, 29 May 2015 08:10:55 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:36701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyJ7i-0000JG-UT for qemu-devel@nongnu.org; Fri, 29 May 2015 08:10:51 -0400 Received: by wivl4 with SMTP id l4so15325896wiv.1 for ; Fri, 29 May 2015 05:10:49 -0700 (PDT) Date: Fri, 29 May 2015 13:10:46 +0100 From: Stefan Hajnoczi Message-ID: <20150529121046.GA8598@stefanha-thinkpad.redhat.com> References: <1432091598-62403-1-git-send-email-sfeldma@gmail.com> <1432091598-62403-5-git-send-email-sfeldma@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lrZ03NoBR/3+SXJZ" Content-Disposition: inline In-Reply-To: <1432091598-62403-5-git-send-email-sfeldma@gmail.com> Subject: Re: [Qemu-devel] [PATCH v2 4/4] qmp/hmp: add rocker device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sfeldma@gmail.com Cc: jiri@resnulli.us, qemu-devel@nongnu.org, dsahern@gmail.com --lrZ03NoBR/3+SXJZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 19, 2015 at 08:13:18PM -0700, sfeldma@gmail.com wrote: > From: Scott Feldman >=20 > v2: >=20 > Address review comments from Stefan Hajnoczi: >=20 > - Add missing qapi/rocker.json file. > - Use PRIx64 for print uint64 value > - when CONFIG_ROCKER is not defined, build qmp-norocker.o stub using > hw/net/Makefile.objs rather than in the top-level Makefile.target qmp-norocker.c is missing from this patch series: make[1]: *** No rule to make target 'hw/net/rocker/qmp-norocker.o', needed = by 'qemu-system-arm'. Stop. > +void hmp_rocker_ports(Monitor *mon, const QDict *qdict) > +{ > + RockerPortList *list, *port; > + const char *name =3D qdict_get_str(qdict, "name"); > + Error *errp =3D NULL; > + > + list =3D qmp_query_rocker_ports(name, &errp); > + if (errp !=3D NULL) { > + hmp_handle_error(mon, &errp); > + return; > + } > + > + monitor_printf(mon, " ena/ speed/ auto\n"); > + monitor_printf(mon, " port link duplex neg?\n"); > + > + for (port =3D list; port; port =3D port->next) Please add curly brackets. QEMU coding style always uses them even for single statement if/for bodies. --lrZ03NoBR/3+SXJZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVaFdGAAoJEJykq7OBq3PIF9gH/iLqUNG7ZesvfUbae0gSYA+L uMTGCVeT7j30z7VmqiESh/PRm89tGPt+ceJy0NFbeCQuubGEq3cUz2vcpdMFLRXY Jok+Bg7dVNC6CO2vj4APQj2twb6XRceBAoJ5R+c3dM/NIazfVWJRAQ5Pb2y+vCBD foYZddjkeJM6uONe/EPCWgrtjGhLwno38e4KzSx8dsfW+XIkeALSw286L8Cw0LDx 46PCUZIiLnA72LYTlFdQELxbTGc8I2Y9f21YQvMCIVriP0fRrDEctUTsOGe3MVaA vgRD+P2kTez6RUMZqUDgJUt5CYp2DsAVxsbnZIVfi8eX2DFC4D5+Ribpmi8/ny8= =Uclu -----END PGP SIGNATURE----- --lrZ03NoBR/3+SXJZ--